chrome/browser/resources/options2/chromeos/virtual_keyboard_list.js - Issue 10391044: retry 136193 - convert localStrings to loadTimeData for options page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options2/chromeos/virtual_keyboard_list.js

Issue 10391044: retry 136193 - convert localStrings to loadTimeData for options page (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: sync Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/options2/chromeos/virtual_keyboard.js ('k') | chrome/browser/resources/options2/clear_browser_data_overlay.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options2/chromeos/virtual_keyboard_list.js

diff --git a/chrome/browser/resources/options2/chromeos/virtual_keyboard_list.js b/chrome/browser/resources/options2/chromeos/virtual_keyboard_list.js

index a16d764a555c0418da7ba58a74835b9d205c0c81..b1d80752fdf469e54fbb9a42dcc528e2c168b7b5 100644

--- a/chrome/browser/resources/options2/chromeos/virtual_keyboard_list.js

+++ b/chrome/browser/resources/options2/chromeos/virtual_keyboard_list.js

@@ -8,8 +8,6 @@ cr.define('options', function() {

/** @const */ var ListItem = cr.ui.ListItem;

/** @const */ var VirtualKeyboardOptions = options.VirtualKeyboardOptions;

- /** @const */ var localStrings = new LocalStrings();

/**

* Creates a virtual keyboard list item.

@@ -56,7 +54,7 @@ cr.define('options', function() {

var defaultOptionElement = document.createElement('option');

defaultOptionElement.selected = (data.preferredKeyboard == null);

defaultOptionElement.textContent =

- localStrings.getString('defaultVirtualKeyboard');

+ loadTimeData.getString('defaultVirtualKeyboard');

defaultOptionElement.value = -1;

selectElement.appendChild(defaultOptionElement);