Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1684)

Unified Diff: chrome/browser/resources/options2/cookies_list.js

Issue 10391044: retry 136193 - convert localStrings to loadTimeData for options page (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sync Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options2/cookies_list.js
diff --git a/chrome/browser/resources/options2/cookies_list.js b/chrome/browser/resources/options2/cookies_list.js
index fa9c16ed6356d6fea5e1dd2feed72fdefc96a7cc..8a4ae577c02f4d747b0f37eddc89e8d827ab04ff 100644
--- a/chrome/browser/resources/options2/cookies_list.js
+++ b/chrome/browser/resources/options2/cookies_list.js
@@ -43,8 +43,6 @@ cr.define('options', function() {
['expires', 'label_server_bound_cert_expires']],
};
- /** @const */ var localStrings = new LocalStrings();
-
/**
* Returns the item's height, like offsetHeight but such that it works better
* when the page is zoomed. See the similar calculation in @{code cr.ui.List}.
@@ -131,7 +129,7 @@ cr.define('options', function() {
this.infoChild.className = 'cookie-details';
this.infoChild.hidden = true;
var remove = this.ownerDocument.createElement('button');
- remove.textContent = localStrings.getString('remove_cookie');
+ remove.textContent = loadTimeData.getString('remove_cookie');
remove.onclick = this.removeCookie_.bind(this);
this.infoChild.appendChild(remove);
var content = this.contentElement;
@@ -237,19 +235,19 @@ cr.define('options', function() {
this.origin.collectSummaryInfo(info);
var list = [];
if (info.cookies > 1)
- list.push(localStrings.getStringF('cookie_plural', info.cookies));
+ list.push(loadTimeData.getStringF('cookie_plural', info.cookies));
else if (info.cookies > 0)
- list.push(localStrings.getString('cookie_singular'));
+ list.push(loadTimeData.getString('cookie_singular'));
if (info.database || info.indexedDb)
- list.push(localStrings.getString('cookie_database_storage'));
+ list.push(loadTimeData.getString('cookie_database_storage'));
if (info.localStorage)
- list.push(localStrings.getString('cookie_local_storage'));
+ list.push(loadTimeData.getString('cookie_local_storage'));
if (info.appCache)
- list.push(localStrings.getString('cookie_app_cache'));
+ list.push(loadTimeData.getString('cookie_app_cache'));
if (info.fileSystem)
- list.push(localStrings.getString('cookie_file_system'));
+ list.push(loadTimeData.getString('cookie_file_system'));
if (info.serverBoundCerts)
- list.push(localStrings.getString('cookie_server_bound_cert'));
+ list.push(loadTimeData.getString('cookie_server_bound_cert'));
var text = '';
for (var i = 0; i < list.length; ++i)
if (text.length > 0)
@@ -478,19 +476,19 @@ cr.define('options', function() {
text = this.data.name;
break;
case 'local_storage':
- text = localStrings.getString('cookie_local_storage');
+ text = loadTimeData.getString('cookie_local_storage');
break;
case 'app_cache':
- text = localStrings.getString('cookie_app_cache');
+ text = loadTimeData.getString('cookie_app_cache');
break;
case 'indexed_db':
- text = localStrings.getString('cookie_indexed_db');
+ text = loadTimeData.getString('cookie_indexed_db');
break;
case 'file_system':
- text = localStrings.getString('cookie_file_system');
+ text = loadTimeData.getString('cookie_file_system');
break;
case 'server_bound_cert':
- text = localStrings.getString('cookie_server_bound_cert');
+ text = loadTimeData.getString('cookie_server_bound_cert');
break;
}
if (!text)
@@ -649,7 +647,7 @@ cr.define('options', function() {
var data = doc.createElement('td');
var pair = cookieInfo[type][i];
name.className = 'cookie-details-label';
- name.textContent = localStrings.getString(pair[1]);
+ name.textContent = loadTimeData.getString(pair[1]);
data.className = 'cookie-details-value';
data.textContent = '';
tr.appendChild(name);
« no previous file with comments | « chrome/browser/resources/options2/controlled_setting.js ('k') | chrome/browser/resources/options2/cookies_view.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698