msvs: error out on actions w/o inputs

msvs: error out on actions w/o inputs

r1378 broke on ninja, not because of command line too long, but because there was no inputs specified in the actions.

Add inputs block to the actions in previously added test, make msvs error out in the same way as other generators. Add verification to input.py.

R=thakis@chromium.org

Committed: https://code.google.com/p/gyp/source/detail?r=1379

[Nico, 2012-05-16 18:48:38]

Hm. make, xcode, and ninja currently all choke on actions without inputs. Maybe
easier to make msvs choke too?

[scottmg, 2012-05-16 19:21:22]

https://chromiumcodereview.appspot.com/10387156/diff/7001/pylib/gyp/input.py
File pylib/gyp/input.py (right):

https://chromiumcodereview.appspot.com/10387156/diff/7001/pylib/gyp/input.py#...
pylib/gyp/input.py:2273: inputs = action.get('inputs', None)
This wasn't doing anything at all before.

I tried "if not inputs:" but there's a few tests that specify an empty set of
inputs (vs no inputs). I guess that should be fine for other generators though?

[Nico, 2012-05-16 19:31:30]

On 2012/05/16 19:21:22, scottmg wrote:
> https://chromiumcodereview.appspot.com/10387156/diff/7001/pylib/gyp/input.py
> File pylib/gyp/input.py (right):
> 
>
https://chromiumcodereview.appspot.com/10387156/diff/7001/pylib/gyp/input.py#...
> pylib/gyp/input.py:2273: inputs = action.get('inputs', None)
> This wasn't doing anything at all before.
> 
> I tried "if not inputs:" but there's a few tests that specify an empty set of
> inputs (vs no inputs). I guess that should be fine for other generators
though?

Yes, `'inputs': []` works fine in the other generators

[Nico, 2012-05-16 19:32:52]

lgtm

https://chromiumcodereview.appspot.com/10387156/diff/7001/test/many-actions/m...
File test/many-actions/many-actions.gyp (right):

https://chromiumcodereview.appspot.com/10387156/diff/7001/test/many-actions/m...
test/many-actions/many-actions.gyp:1807: 'inputs': ['input'],
Just [] might be enough

[scottmg, 2012-05-16 19:35:34]

https://chromiumcodereview.appspot.com/10387156/diff/7001/test/many-actions/m...
File test/many-actions/many-actions.gyp (right):

https://chromiumcodereview.appspot.com/10387156/diff/7001/test/many-actions/m...
test/many-actions/many-actions.gyp:1807: 'inputs': ['input'],
On 2012/05/16 19:32:52, Nico wrote:
> Just [] might be enough

Done.