msvs: error out on actions w/o inputs

pylib/gyp/input.py

 # Copyright (c) 2012 Google Inc. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from compiler.ast import Const
 from compiler.ast import Dict
 from compiler.ast import Discard
 from compiler.ast import List
 from compiler.ast import Module
 from compiler.ast import Node
@@ skipping 2252 matching lines @@
 def ValidateActionsInTarget(target, target_dict, build_file):
   '''Validates the inputs to the actions in a target.'''
   target_name = target_dict.get('target_name')
   actions = target_dict.get('actions', [])
   for action in actions:
     action_name = action.get('action_name')
     if not action_name:
       raise Exception("Anonymous action in target %s.  "
                       "An action must have an 'action_name' field." %
                       target_name)
-    inputs = action.get('inputs', [])
+    inputs = action.get('inputs', None)

[scottmg, 2012/05/16 19:21:23]

This wasn't doing anything at all before.

I tried "if not inputs:" but there's a few tests that specify an empty set of
inputs (vs no inputs). I guess that should be fine for other generators though?

+    if inputs is None:
+      raise Exception('Action in target %s has no inputs.' % target_name)
     action_command = action.get('action')
     if action_command and not action_command[0]:
       raise Exception("Empty action as command in target %s." % target_name)
 
 
 def TurnIntIntoStrInDict(the_dict):
   """Given dict the_dict, recursively converts all integers into strings.
   """
   # Use items instead of iteritems because there's no need to try to look at
   # reinserted keys and their associated values.
@@ skipping 195 matching lines @@
     ValidateRunAsInTarget(target, target_dict, build_file)
     ValidateActionsInTarget(target, target_dict, build_file)
 
   # Generators might not expect ints.  Turn them into strs.
   TurnIntIntoStrInDict(data)
 
   # TODO(mark): Return |data| for now because the generator needs a list of
   # build files that came in.  In the future, maybe it should just accept
   # a list, and not the whole data dict.
   return [flat_list, targets, data]