Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Side by Side Diff: pylib/gyp/generator/msvs.py

Issue 10387156: msvs: error out on actions w/o inputs (Closed) Base URL: https://gyp.googlecode.com/svn/trunk
Patch Set: empty inputs Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | pylib/gyp/input.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 Google Inc. All rights reserved. 1 # Copyright (c) 2012 Google Inc. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import copy 5 import copy
6 import ntpath 6 import ntpath
7 import os 7 import os
8 import posixpath 8 import posixpath
9 import re 9 import re
10 import subprocess 10 import subprocess
(...skipping 1256 matching lines...) Expand 10 before | Expand all | Expand 10 after
1267 The sources will be relative to the gyp file. 1267 The sources will be relative to the gyp file.
1268 """ 1268 """
1269 sources = set() 1269 sources = set()
1270 _AddNormalizedSources(sources, spec.get('sources', [])) 1270 _AddNormalizedSources(sources, spec.get('sources', []))
1271 excluded_sources = set() 1271 excluded_sources = set()
1272 # Add in the gyp file. 1272 # Add in the gyp file.
1273 sources.add(gyp_file) 1273 sources.add(gyp_file)
1274 1274
1275 # Add in 'action' inputs and outputs. 1275 # Add in 'action' inputs and outputs.
1276 for a in spec.get('actions', []): 1276 for a in spec.get('actions', []):
1277 inputs = a.get('inputs', []) 1277 inputs = a['inputs']
1278 inputs = [_NormalizedSource(i) for i in inputs] 1278 inputs = [_NormalizedSource(i) for i in inputs]
1279 # Add all inputs to sources and excluded sources. 1279 # Add all inputs to sources and excluded sources.
1280 inputs = set(inputs) 1280 inputs = set(inputs)
1281 sources.update(inputs) 1281 sources.update(inputs)
1282 excluded_sources.update(inputs) 1282 excluded_sources.update(inputs)
1283 if int(a.get('process_outputs_as_sources', False)): 1283 if int(a.get('process_outputs_as_sources', False)):
1284 _AddNormalizedSources(sources, a.get('outputs', [])) 1284 _AddNormalizedSources(sources, a.get('outputs', []))
1285 # Add in 'copies' inputs and outputs. 1285 # Add in 'copies' inputs and outputs.
1286 for cpy in spec.get('copies', []): 1286 for cpy in spec.get('copies', []):
1287 _AddNormalizedSources(sources, cpy.get('files', [])) 1287 _AddNormalizedSources(sources, cpy.get('files', []))
(...skipping 1829 matching lines...) Expand 10 before | Expand all | Expand 10 after
3117 action_spec.extend( 3117 action_spec.extend(
3118 # TODO(jeanluc) 'Document' for all or just if as_sources? 3118 # TODO(jeanluc) 'Document' for all or just if as_sources?
3119 [['FileType', 'Document'], 3119 [['FileType', 'Document'],
3120 ['Command', command], 3120 ['Command', command],
3121 ['Message', description], 3121 ['Message', description],
3122 ['Outputs', outputs] 3122 ['Outputs', outputs]
3123 ]) 3123 ])
3124 if additional_inputs: 3124 if additional_inputs:
3125 action_spec.append(['AdditionalInputs', additional_inputs]) 3125 action_spec.append(['AdditionalInputs', additional_inputs])
3126 actions_spec.append(action_spec) 3126 actions_spec.append(action_spec)
OLDNEW
« no previous file with comments | « no previous file | pylib/gyp/input.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698