Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1200)

Unified Diff: pylib/gyp/input.py

Issue 10387156: msvs: error out on actions w/o inputs (Closed) Base URL: https://gyp.googlecode.com/svn/trunk
Patch Set: empty inputs Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pylib/gyp/generator/msvs.py ('k') | test/many-actions/many-actions.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pylib/gyp/input.py
diff --git a/pylib/gyp/input.py b/pylib/gyp/input.py
index 27c71b1acaa22b1b92700eb1aecfd84c643660ab..568049df6c349c6dae60fcbd966e73a0c628a7ee 100644
--- a/pylib/gyp/input.py
+++ b/pylib/gyp/input.py
@@ -2270,7 +2270,9 @@ def ValidateActionsInTarget(target, target_dict, build_file):
raise Exception("Anonymous action in target %s. "
"An action must have an 'action_name' field." %
target_name)
- inputs = action.get('inputs', [])
+ inputs = action.get('inputs', None)
+ if inputs is None:
+ raise Exception('Action in target %s has no inputs.' % target_name)
action_command = action.get('action')
if action_command and not action_command[0]:
raise Exception("Empty action as command in target %s." % target_name)
« no previous file with comments | « pylib/gyp/generator/msvs.py ('k') | test/many-actions/many-actions.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698