pylib/gyp/generator/msvs.py - Issue 10387156: msvs: error out on actions w/o inputs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pylib/gyp/generator/msvs.py

Issue 10387156: msvs: error out on actions w/o inputs (Closed) Base URL: https://gyp.googlecode.com/svn/trunk

Patch Set: empty inputs Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pylib/gyp/generator/msvs.py

diff --git a/pylib/gyp/generator/msvs.py b/pylib/gyp/generator/msvs.py

index 24227047b22c92ff83ada1c242985ef7f35021b8..2d15a3570836b33afe08d5f303bd22c316e28cad 100644

--- a/pylib/gyp/generator/msvs.py

+++ b/pylib/gyp/generator/msvs.py

@@ -1274,7 +1274,7 @@ def _PrepareListOfSources(spec, gyp_file):

# Add in 'action' inputs and outputs.

for a in spec.get('actions', []):

- inputs = a.get('inputs', [])

+ inputs = a['inputs']

inputs = [_NormalizedSource(i) for i in inputs]

# Add all inputs to sources and excluded sources.

inputs = set(inputs)

« no previous file with comments | « no previous file | pylib/gyp/input.py » ('j') | no next file with comments »