Issue 10332269: RefCounted types should not have public destructors, base/ edition

Issue 10332269: RefCounted types should not have public destructors, base/ edition (Closed)

Created:
8 years, 7 months ago by Ryan Sleevi

Modified:
8 years, 6 months ago

Reviewers:
jar (doing other things)

CC:
chromium-reviews, erikwright (departed), sadrul, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

RefCounted types should not have public destructors, base/ edition BUG=123295 TEST=it compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144130

Patch Set 1 #

Patch Set 2 : Rebase to r140259 #

Patch Set 3 : Rebase to ToT #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -25 lines)			Patch
M	base/memory/ref_counted.h	View	1 2	4 chunks	+8 lines, -4 lines	0 comments	Download
M	base/memory/weak_ptr.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	base/message_pump_libevent.h	View	1 2	2 chunks	+4 lines, -2 lines	0 comments	Download
M	base/supports_user_data.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	base/supports_user_data.cc	View		2 chunks	+3 lines, -5 lines	0 comments	Download
M	base/synchronization/waitable_event_watcher.h	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	base/threading/non_thread_safe.h	View		2 chunks	+3 lines, -4 lines	0 comments	Download
M	base/threading/non_thread_safe_impl.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	base/threading/non_thread_safe_impl.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	base/threading/platform_thread.h	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Ryan Sleevi

jar: These changes require landing fixes for the other directories first - especially the NonThreadSafe ...

8 years, 7 months ago (2012-05-21 08:16:32 UTC) #1

jar (doing other things)

LGTM... but please try to satisfy all folks that are strongly opinionated.

8 years, 7 months ago (2012-05-23 02:04:37 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10332269/7001

8 years, 6 months ago (2012-06-26 01:10:07 UTC) #3

commit-bot: I haz the power

Try job failure for 10332269-7001 on win for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=17257 Step "update" is always ...

8 years, 6 months ago (2012-06-26 01:44:51 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10332269/7001

8 years, 6 months ago (2012-06-26 04:44:48 UTC) #5

Change committed as 144130

Expand Messages | Collapse Messages