Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4159)

Unified Diff: base/supports_user_data.h

Issue 10332269: RefCounted types should not have public destructors, base/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase to ToT Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/message_pump_libevent.h ('k') | base/supports_user_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/supports_user_data.h
diff --git a/base/supports_user_data.h b/base/supports_user_data.h
index d1c6c9a899eec6af4c0c2f3fba3dbad4db6b90e8..17899dd9c7893fe4929424bbb841e05b02e71a18 100644
--- a/base/supports_user_data.h
+++ b/base/supports_user_data.h
@@ -18,7 +18,6 @@ namespace base {
class BASE_EXPORT SupportsUserData {
public:
SupportsUserData();
- virtual ~SupportsUserData();
// Derive from this class and add your own data members to associate extra
// information with this object. Use GetUserData(key) and SetUserData()
@@ -34,6 +33,9 @@ class BASE_EXPORT SupportsUserData {
Data* GetUserData(const void* key) const;
void SetUserData(const void* key, Data* data);
+ protected:
+ virtual ~SupportsUserData();
+
private:
typedef std::map<const void*, linked_ptr<Data> > DataMap;
« no previous file with comments | « base/message_pump_libevent.h ('k') | base/supports_user_data.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698