Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: base/message_pump_libevent.h

Issue 10332269: RefCounted types should not have public destructors, base/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase to ToT Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/memory/weak_ptr.h ('k') | base/supports_user_data.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/message_pump_libevent.h
diff --git a/base/message_pump_libevent.h b/base/message_pump_libevent.h
index 957c5480b465f699d3e36a56e2eb7cdf4ec3e1ce..1666ad075d05d29e7cc0363cbca285c5d928d31e 100644
--- a/base/message_pump_libevent.h
+++ b/base/message_pump_libevent.h
@@ -45,11 +45,13 @@ class BASE_EXPORT MessagePumpLibevent : public MessagePump {
// of a file descriptor.
class Watcher {
public:
- virtual ~Watcher() {}
// Called from MessageLoop::Run when an FD can be read from/written to
// without blocking
virtual void OnFileCanReadWithoutBlocking(int fd) = 0;
virtual void OnFileCanWriteWithoutBlocking(int fd) = 0;
+
+ protected:
+ virtual ~Watcher() {}
};
// Object returned by WatchFileDescriptor to manage further watching.
@@ -74,7 +76,7 @@ class BASE_EXPORT MessagePumpLibevent : public MessagePump {
void Init(event* e);
// Used by MessagePumpLibevent to take ownership of event_.
- event *ReleaseEvent();
+ event* ReleaseEvent();
void set_pump(MessagePumpLibevent* pump) { pump_ = pump; }
MessagePumpLibevent* pump() { return pump_; }
« no previous file with comments | « base/memory/weak_ptr.h ('k') | base/supports_user_data.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698