base/memory/weak_ptr.h - Issue 10332269: RefCounted types should not have public destructors, base/ edition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/memory/weak_ptr.h

Issue 10332269: RefCounted types should not have public destructors, base/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase to ToT Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/memory/weak_ptr.h

diff --git a/base/memory/weak_ptr.h b/base/memory/weak_ptr.h

index be045a61b81c7dc85d4b5ba53ac30c30544b3ce7..d7c452f1dbb0f796cd6e23f21542a606ee8fe10e 100644

--- a/base/memory/weak_ptr.h

+++ b/base/memory/weak_ptr.h

@@ -251,6 +251,9 @@ class SupportsWeakPtr : public internal::SupportsWeakPtrBase {

weak_reference_owner_.DetachFromThread();

}

+ protected:

+ ~SupportsWeakPtr() {}

private:

internal::WeakReferenceOwner weak_reference_owner_;

DISALLOW_COPY_AND_ASSIGN(SupportsWeakPtr);

« no previous file with comments | « base/memory/ref_counted.h ('k') | base/message_pump_libevent.h » ('j') | no next file with comments »