Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(795)

Unified Diff: base/threading/non_thread_safe.h

Issue 10332269: RefCounted types should not have public destructors, base/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase to ToT Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/synchronization/waitable_event_watcher.h ('k') | base/threading/non_thread_safe_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/threading/non_thread_safe.h
diff --git a/base/threading/non_thread_safe.h b/base/threading/non_thread_safe.h
index 3f60fed8890f517ccf89a206433d6887481fb32e..8609ccb0ac0c361d37a6d749ac0750f7c44d564c 100644
--- a/base/threading/non_thread_safe.h
+++ b/base/threading/non_thread_safe.h
@@ -29,6 +29,7 @@ class NonThreadSafeDoNothing {
}
protected:
+ ~NonThreadSafeDoNothing() {}
void DetachFromThread() {}
};
@@ -51,11 +52,9 @@ class NonThreadSafeDoNothing {
// In Release mode, CalledOnValidThread will always return true.
//
#ifndef NDEBUG
-class NonThreadSafe : public NonThreadSafeImpl {
-};
+typedef NonThreadSafeImpl NonThreadSafe;
#else
-class NonThreadSafe : public NonThreadSafeDoNothing {
-};
+typedef NonThreadSafeDoNothing NonThreadSafe;
#endif // NDEBUG
} // namespace base
« no previous file with comments | « base/synchronization/waitable_event_watcher.h ('k') | base/threading/non_thread_safe_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698