Issue 10161010: Handle IQ responses asynchronously.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10161010: Handle IQ responses asynchronously. (Closed)

Created:
8 years, 8 months ago by Sergey Ulanov

Modified:
8 years, 8 months ago

Reviewers:
simonmorris

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Handle IQ responses asynchronously. Previously IqRequest was calling response callback synchronously. The callback is allowed to delete SignalStrategy object, but it may be unsafe to delete XmppSignalStrategy when handling an incoming message. Fixed IqRequest to invoke response callback asynchronously, so that the callback is called with a clean stack. BUG=124430 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133302

Patch Set 1 #

Patch Set 2 : fix unittests #

Patch Set 3 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -5 lines)			Patch
M	remoting/jingle_glue/iq_sender.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	remoting/jingle_glue/iq_sender.cc	View		2 chunks	+11 lines, -1 line	0 comments	Download
M	remoting/jingle_glue/iq_sender_unittest.cc	View	1 2	4 chunks	+12 lines, -3 lines	0 comments	Download
M	remoting/jingle_glue/signal_strategy.h	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10161010/1

8 years, 8 months ago (2012-04-20 20:45:40 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10161010/4002

8 years, 8 months ago (2012-04-20 21:13:10 UTC) #4

commit-bot: I haz the power

8 years, 8 months ago (2012-04-20 21:13:33 UTC) #5

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10161010/9001

Expand Messages | Collapse Messages