Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Unified Diff: remoting/jingle_glue/iq_sender_unittest.cc

Issue 10161010: Handle IQ responses asynchronously. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/jingle_glue/iq_sender.cc ('k') | remoting/jingle_glue/signal_strategy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/jingle_glue/iq_sender_unittest.cc
diff --git a/remoting/jingle_glue/iq_sender_unittest.cc b/remoting/jingle_glue/iq_sender_unittest.cc
index 06730f5de18fe4208e37b48b3957f3817429b1f3..a5f02a53db859874242469d802de50f44f77e912 100644
--- a/remoting/jingle_glue/iq_sender_unittest.cc
+++ b/remoting/jingle_glue/iq_sender_unittest.cc
@@ -39,6 +39,10 @@ class MockCallback {
MOCK_METHOD2(OnReply, void(IqRequest* request, const XmlElement* reply));
};
+MATCHER_P(XmlEq, expected, "") {
+ return arg->Str() == expected->Str();
+}
+
} // namespace
class IqSenderTest : public testing::Test {
@@ -95,8 +99,10 @@ TEST_F(IqSenderTest, SendIq) {
QName("test:namespace", "response-body"));
response->AddElement(result);
- EXPECT_CALL(callback_, OnReply(request_.get(), response.get()));
EXPECT_TRUE(sender_->OnSignalStrategyIncomingStanza(response.get()));
+
+ EXPECT_CALL(callback_, OnReply(request_.get(), XmlEq(response.get())));
+ message_loop_.RunAllPending();
}
TEST_F(IqSenderTest, Timeout) {
@@ -125,9 +131,10 @@ TEST_F(IqSenderTest, InvalidFrom) {
QName("test:namespace", "response-body"));
response->AddElement(result);
- EXPECT_CALL(callback_, OnReply(request_.get(), response.get()))
+ EXPECT_CALL(callback_, OnReply(_, _))
.Times(0);
EXPECT_FALSE(sender_->OnSignalStrategyIncomingStanza(response.get()));
+ message_loop_.RunAllPending();
}
TEST_F(IqSenderTest, IdMatchingHack) {
@@ -144,8 +151,10 @@ TEST_F(IqSenderTest, IdMatchingHack) {
QName("test:namespace", "response-body"));
response->AddElement(result);
- EXPECT_CALL(callback_, OnReply(request_.get(), response.get()));
EXPECT_TRUE(sender_->OnSignalStrategyIncomingStanza(response.get()));
+
+ EXPECT_CALL(callback_, OnReply(request_.get(), XmlEq(response.get())));
+ message_loop_.RunAllPending();
}
} // namespace remoting
« no previous file with comments | « remoting/jingle_glue/iq_sender.cc ('k') | remoting/jingle_glue/signal_strategy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698