Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Side by Side Diff: remoting/jingle_glue/iq_sender.cc

Issue 10161010: Handle IQ responses asynchronously. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « remoting/jingle_glue/iq_sender.h ('k') | remoting/jingle_glue/iq_sender_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "remoting/jingle_glue/iq_sender.h" 5 #include "remoting/jingle_glue/iq_sender.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/location.h" 8 #include "base/location.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/memory/scoped_ptr.h"
10 #include "base/message_loop_proxy.h" 11 #include "base/message_loop_proxy.h"
11 #include "base/string_number_conversions.h" 12 #include "base/string_number_conversions.h"
12 #include "base/time.h" 13 #include "base/time.h"
13 #include "remoting/jingle_glue/signal_strategy.h" 14 #include "remoting/jingle_glue/signal_strategy.h"
14 #include "third_party/libjingle/source/talk/xmllite/xmlelement.h" 15 #include "third_party/libjingle/source/talk/xmllite/xmlelement.h"
15 #include "third_party/libjingle/source/talk/xmpp/constants.h" 16 #include "third_party/libjingle/source/talk/xmpp/constants.h"
16 17
17 namespace remoting { 18 namespace remoting {
18 19
19 // static 20 // static
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
155 callback_.Reset(); 156 callback_.Reset();
156 callback.Run(this, stanza); 157 callback.Run(this, stanza);
157 } 158 }
158 } 159 }
159 160
160 void IqRequest::OnTimeout() { 161 void IqRequest::OnTimeout() {
161 CallCallback(NULL); 162 CallCallback(NULL);
162 } 163 }
163 164
164 void IqRequest::OnResponse(const buzz::XmlElement* stanza) { 165 void IqRequest::OnResponse(const buzz::XmlElement* stanza) {
165 CallCallback(stanza); 166 // It's unsafe to delete signal strategy here, and the callback may
167 // want to do that, so we post task to invoke the callback later.
168 scoped_ptr<buzz::XmlElement> stanza_copy(new buzz::XmlElement(*stanza));
169 base::MessageLoopProxy::current()->PostTask(
170 FROM_HERE, base::Bind(&IqRequest::DeliverResponse, AsWeakPtr(),
171 base::Passed(&stanza_copy)));
172 }
173
174 void IqRequest::DeliverResponse(scoped_ptr<buzz::XmlElement> stanza) {
175 CallCallback(stanza.get());
166 } 176 }
167 177
168 } // namespace remoting 178 } // namespace remoting
OLDNEW
« no previous file with comments | « remoting/jingle_glue/iq_sender.h ('k') | remoting/jingle_glue/iq_sender_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698