Handle IQ responses asynchronously.

remoting/jingle_glue/iq_sender_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/memory/ref_counted.h"
 #include "base/message_loop.h"
 #include "base/stringprintf.h"
 #include "remoting/jingle_glue/iq_sender.h"
 #include "remoting/jingle_glue/mock_objects.h"
@@ skipping 21 matching lines @@
 const char kNamespacePrefix[] = "tes";
 const char kBodyTag[] = "test";
 const char kType[] = "get";
 const char kTo[] = "user@domain.com";
 
 class MockCallback {
  public:
   MOCK_METHOD2(OnReply, void(IqRequest* request, const XmlElement* reply));
 };
 
+MATCHER_P(XmlEq, expected, "") {
+  return arg->Str() == expected->Str();
+}
+
 }  // namespace
 
 class IqSenderTest : public testing::Test {
  public:
   IqSenderTest() {
     EXPECT_CALL(signal_strategy_, AddListener(NotNull()));
     sender_.reset(new IqSender(&signal_strategy_));
     EXPECT_CALL(signal_strategy_, RemoveListener(
         static_cast<SignalStrategy::Listener*>(sender_.get())));
   }
@@ skipping 36 matching lines @@
 
   scoped_ptr<XmlElement> response(new XmlElement(buzz::QN_IQ));
   response->AddAttr(QName("", "type"), "result");
   response->AddAttr(QName("", "id"), kStanzaId);
   response->AddAttr(QName("", "from"), kTo);
 
   XmlElement* result = new XmlElement(
       QName("test:namespace", "response-body"));
   response->AddElement(result);
 
-  EXPECT_CALL(callback_, OnReply(request_.get(), response.get()));
   EXPECT_TRUE(sender_->OnSignalStrategyIncomingStanza(response.get()));
+
+  EXPECT_CALL(callback_, OnReply(request_.get(), XmlEq(response.get())));
+  message_loop_.RunAllPending();
 }
 
 TEST_F(IqSenderTest, Timeout) {
   ASSERT_NO_FATAL_FAILURE({
     SendTestMessage();
   });
 
   request_->SetTimeout(base::TimeDelta::FromMilliseconds(2));
 
   EXPECT_CALL(callback_, OnReply(request_.get(), NULL))
       .WillOnce(InvokeWithoutArgs(&message_loop_, &MessageLoop::Quit));
   message_loop_.Run();
 }
 
 TEST_F(IqSenderTest, InvalidFrom) {
   ASSERT_NO_FATAL_FAILURE({
     SendTestMessage();
   });
 
   scoped_ptr<XmlElement> response(new XmlElement(buzz::QN_IQ));
   response->AddAttr(QName("", "type"), "result");
   response->AddAttr(QName("", "id"), kStanzaId);
   response->AddAttr(QName("", "from"), "different_user@domain.com");
 
   XmlElement* result = new XmlElement(
       QName("test:namespace", "response-body"));
   response->AddElement(result);
 
-  EXPECT_CALL(callback_, OnReply(request_.get(), response.get()))
+  EXPECT_CALL(callback_, OnReply(_, _))
       .Times(0);
   EXPECT_FALSE(sender_->OnSignalStrategyIncomingStanza(response.get()));
+  message_loop_.RunAllPending();
 }
 
 TEST_F(IqSenderTest, IdMatchingHack) {
   ASSERT_NO_FATAL_FAILURE({
     SendTestMessage();
   });
 
   scoped_ptr<XmlElement> response(new XmlElement(buzz::QN_IQ));
   response->AddAttr(QName("", "type"), "result");
   response->AddAttr(QName("", "id"), "DIFFERENT_ID");
   response->AddAttr(QName("", "from"), kTo);
 
   XmlElement* result = new XmlElement(
       QName("test:namespace", "response-body"));
   response->AddElement(result);
 
-  EXPECT_CALL(callback_, OnReply(request_.get(), response.get()));
   EXPECT_TRUE(sender_->OnSignalStrategyIncomingStanza(response.get()));
+
+  EXPECT_CALL(callback_, OnReply(request_.get(), XmlEq(response.get())));
+  message_loop_.RunAllPending();
 }
 
 }  // namespace remoting