Issue 10854013: Clean up the test srapper code so that it does not use reportTestError, and made that private.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10854013: Clean up the test srapper code so that it does not use reportTestError, and made that private. (Closed)

Created:
8 years, 4 months ago by gram

Modified:
8 years, 4 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Clean up the test wrapper code so that it does not use reportTestError, and made that private. The HTML configs still need a way of reporting errors so I added a method to Config which can be used for this purpose. This seems a bit cleaner and more flexible, as configs can now override this. Committed: https://code.google.com/p/dart/source/detail?r=10311

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -33 lines)			Patch
M	lib/unittest/config.dart	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
M	lib/unittest/dom_config.dart	View	1	1 chunk	+2 lines, -5 lines	0 comments	Download
M	lib/unittest/html_config.dart	View	1	1 chunk	+2 lines, -5 lines	0 comments	Download
M	lib/unittest/html_enhanced_config.dart	View	1	1 chunk	+2 lines, -5 lines	0 comments	Download
M	lib/unittest/interactive_html_config.dart	View	1	2 chunks	+4 lines, -10 lines	0 comments	Download
M	lib/unittest/unittest.dart	View		2 chunks	+3 lines, -1 line	2 comments	Download
M	tools/testing/dart/browser_test.dart	View		1 chunk	+1 line, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

8 years, 4 months ago (2012-08-06 21:42:49 UTC) #2

lgm

https://chromiumcodereview.appspot.com/10854013/diff/3008/lib/unittest/unitte...
File lib/unittest/unittest.dart (right):

https://chromiumcodereview.appspot.com/10854013/diff/3008/lib/unittest/unitte...
lib/unittest/unittest.dart:585: } catch(var e, var trace) {
I wonder if somewhere we relied on the fact that his was letting the exceptions
pass through ?

https://chromiumcodereview.appspot.com/10854013/diff/3008/lib/unittest/unitte...
lib/unittest/unittest.dart:663: *  error was caught outside of this library.
remove extra space:
*  error
 =>
* error

Expand Messages | Collapse Messages