Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: lib/unittest/interactive_html_config.dart

Issue 10854013: Clean up the test srapper code so that it does not use reportTestError, and made that private. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/unittest/interactive_html_config.dart
===================================================================
--- lib/unittest/interactive_html_config.dart (revision 10299)
+++ lib/unittest/interactive_html_config.dart (working copy)
@@ -73,11 +73,8 @@
get autoStart() => false;
void onInit() {
- _onErrorClosure = (e) {
- // TODO(vsm): figure out how to expose the stack trace here
- // Currently e.message works in dartium, but not in dartc.
- reportTestError('(DOM callback has errors) Caught ${e}', '');
- };
+ _onErrorClosure =
+ (e) => handleExternalError(e, '(DOM callback has errors)');
/**
* The master posts a 'start' message to kick things off,
@@ -226,11 +223,8 @@
void onInit() {
_messageHandler = _handleMessage; // We need to make just one closure.
- _onErrorClosure = (e) {
- // TODO(vsm): figure out how to expose the stack trace here
- // Currently e.message works in dartium, but not in dartc.
- reportTestError('(DOM callback has errors) Caught ${e}', '');
- };
+ _onErrorClosure =
+ (e) => handleExternalError(e, '(DOM callback has errors)');
document.query('#group-divs').innerHTML = "";
}

Powered by Google App Engine
This is Rietveld 408576698