Clean up the test srapper code so that it does not use reportTestError, and made that private.

lib/unittest/unittest.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * A library for writing dart unit tests.
  *
  * To import this library, specify the relative path to
  * lib/unittest/unittest.dart.
  *
@@ skipping 564 matching lines @@
 
   // Groups can be nested, so we need to preserve the current
   // settings for test setup/teardown.
   Function parentSetup = _testSetup;
   Function parentTeardown = _testTeardown;
 
   try {
     _testSetup = null;
     _testTeardown = null;
     body();
+  } catch(var e, var trace) {

[Siggi Cherem (dart-lang), 2012/08/06 21:42:49]

I wonder if somewhere we relied on the fact that his was letting the exceptions
pass through ?

+    _reportTestError(e.toString(), trace == null ? '' : trace.toString());
   } finally {
     // Now that the group is over, restore the previous one.
     _currentGroup = parentGroup;
     _testSetup = parentSetup;
     _testTeardown = parentTeardown;
   }
 }
 
 /**
  * Register a [setUp] function for a test [group]. This function will
@@ skipping 56 matching lines @@
 /**
  * Temporary hack: expose old API.
  * TODO(gram) remove this when WebKit tests are working with new framework
  */
 void callbackDone() {
   _handleCallbackFunctionComplete();
 }
 
 /**
  * Utility function that can be used to notify the test framework that an
  *  error was caught outside of this library.

[Siggi Cherem (dart-lang), 2012/08/06 21:42:49]

remove extra space:
*  error
 =>
* error

  */
-void reportTestError(String msg, String trace) {
+void _reportTestError(String msg, String trace) {
  if (_currentTest < _tests.length) {
     final testCase = _tests[_currentTest];
     testCase.error(msg, trace);
     if (testCase.callbackFunctionsOutstanding > 0) {
       _nextTestCase();
     }
   } else {
     _uncaughtErrorMessage = "$msg: $trace";
   }
 }
@@ skipping 168 matching lines @@
 }
 
 /** Enable a test by ID. */
 void enableTest(int testId) => _setTestEnabledState(testId, true);
 
 /** Disable a test by ID. */
 void disableTest(int testId) => _setTestEnabledState(testId, false);
 
 /** Signature for a test function. */
 typedef void TestFunction();