Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: lib/unittest/config.dart

Issue 10854013: Clean up the test srapper code so that it does not use reportTestError, and made that private. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/unittest/dom_config.dart » ('j') | lib/unittest/unittest.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/unittest/config.dart
===================================================================
--- lib/unittest/config.dart (revision 10299)
+++ lib/unittest/config.dart (working copy)
@@ -129,4 +129,10 @@
return Strings.join(str.split("\n").map((line) => " $line"), "\n");
}
+
+ /** Handle errors that happen outside the tests. */
+ // TODO(vsm): figure out how to expose the stack trace here
+ // Currently e.message works in dartium, but not in dartc.
+ handleExternalError(e, String message) =>
+ _reportTestError('$message\nCaught $e', '');
}
« no previous file with comments | « no previous file | lib/unittest/dom_config.dart » ('j') | lib/unittest/unittest.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698