Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: lib/unittest/unittest.dart

Issue 10854013: Clean up the test srapper code so that it does not use reportTestError, and made that private. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/unittest/interactive_html_config.dart ('k') | tools/testing/dart/browser_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/unittest/unittest.dart
===================================================================
--- lib/unittest/unittest.dart (revision 10299)
+++ lib/unittest/unittest.dart (working copy)
@@ -582,6 +582,8 @@
_testSetup = null;
_testTeardown = null;
body();
+ } catch(var e, var trace) {
Siggi Cherem (dart-lang) 2012/08/06 21:42:49 I wonder if somewhere we relied on the fact that h
+ _reportTestError(e.toString(), trace == null ? '' : trace.toString());
} finally {
// Now that the group is over, restore the previous one.
_currentGroup = parentGroup;
@@ -660,7 +662,7 @@
* Utility function that can be used to notify the test framework that an
* error was caught outside of this library.
Siggi Cherem (dart-lang) 2012/08/06 21:42:49 remove extra space: * error => * error
*/
-void reportTestError(String msg, String trace) {
+void _reportTestError(String msg, String trace) {
if (_currentTest < _tests.length) {
final testCase = _tests[_currentTest];
testCase.error(msg, trace);
« no previous file with comments | « lib/unittest/interactive_html_config.dart ('k') | tools/testing/dart/browser_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698