Deprecate Math object in corelib in favor of dart:math library.

Deprecate Math object in corelib in favor of dart:math library.

Committed: https://code.google.com/p/dart/source/detail?r=11155

[Mads Ager (google), 2012-08-21 17:19:49]

Auch, this is passing tests locally, but I'm sure I have missed something
somewhere. Time will tell.

Konstantin, could you have a look at the java tests I have changed. It looks
like type propagation. I couldn't find a good way to update those. If you could
update them separately afterwards (or find the one who can) that would be great.

[Mads Ager (google), 2012-08-21 17:26:02]

Ivan, could you have a look at runtime/vm/object.cc changes to import dart:math
in core and coreimpl?

[scheglov, 2012-08-21 18:26:42]

> Konstantin, could you have a look at the java tests I have changed. It looks
> like type propagation. I couldn't find a good way to update those. If you
could
> update them separately afterwards (or find the one who can) that would be
great.

Mads, I will updated these tests later.

[ahe, 2012-08-21 19:50:52]

lib/compiler LGTM. Nice work!

[Anders Johnsen, 2012-08-22 07:37:53]

LGTM!

https://chromiumcodereview.appspot.com/10829459/diff/1/runtime/bin/websocket_...
File runtime/bin/websocket_impl.dart (right):

https://chromiumcodereview.appspot.com/10829459/diff/1/runtime/bin/websocket_...
runtime/bin/websocket_impl.dart:742: int r = (random.nextDouble() *
0x100000000).toInt();
Use nextInt(0x100000000)?

https://chromiumcodereview.appspot.com/10829459/diff/1/runtime/bin/websocket_...
runtime/bin/websocket_impl.dart:746: _hash = (random.nextDouble() *
0x100000000).toInt();
Ditto.

https://chromiumcodereview.appspot.com/10829459/diff/1/tests/corelib/math_tes...
File tests/corelib/math_test.dart (right):

https://chromiumcodereview.appspot.com/10829459/diff/1/tests/corelib/math_tes...
tests/corelib/math_test.dart:9: #import('dart:math', prefix: 'math');
Should we remove this file entirely? It's not part of corelib anymore.

[Mads Ager (google), 2012-08-22 13:42:41]

https://chromiumcodereview.appspot.com/10829459/diff/1/runtime/bin/websocket_...
File runtime/bin/websocket_impl.dart (right):

https://chromiumcodereview.appspot.com/10829459/diff/1/runtime/bin/websocket_...
runtime/bin/websocket_impl.dart:742: int r = (random.nextDouble() *
0x100000000).toInt();
On 2012/08/22 07:37:53, ajohnsen wrote:
> Use nextInt(0x100000000)?

Done.

https://chromiumcodereview.appspot.com/10829459/diff/1/runtime/bin/websocket_...
runtime/bin/websocket_impl.dart:746: _hash = (random.nextDouble() *
0x100000000).toInt();
On 2012/08/22 07:37:53, ajohnsen wrote:
> Ditto.

Done.

https://chromiumcodereview.appspot.com/10829459/diff/1/tests/corelib/math_tes...
File tests/corelib/math_test.dart (right):

https://chromiumcodereview.appspot.com/10829459/diff/1/tests/corelib/math_tes...
tests/corelib/math_test.dart:9: #import('dart:math', prefix: 'math');
On 2012/08/22 07:37:53, ajohnsen wrote:
> Should we remove this file entirely? It's not part of corelib anymore.

We should probably move these files to the tests/lib/math directory. I will do
that.