runtime/vm/object.cc - Issue 10829459: Deprecate Math object in corelib in favor of dart:math library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object.cc

Issue 10829459: Deprecate Math object in corelib in favor of dart:math library. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address review comments. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/object.cc

diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc

index 5f8a04f5d15a96827f660812c5af312cf733e4e8..34493ccca24e89b5b0eb202c152cf45b351e16fb 100644

--- a/runtime/vm/object.cc

+++ b/runtime/vm/object.cc

@@ -859,7 +859,6 @@ RawError* Object::Init(Isolate* isolate) {

return error.raw();

}

const Script& math_script = Script::Handle(Bootstrap::LoadMathScript(false));

- Library::InitMathLibrary(isolate);

const Library& math_lib = Library::Handle(Library::MathLibrary());

ASSERT(!math_lib.IsNull());

error = Bootstrap::Compile(math_lib, math_script);

@@ -6179,6 +6178,10 @@ void Library::InitCoreLibrary(Isolate* isolate) {

core_impl_lib.Register();

core_lib.AddImport(core_impl_lib);

core_impl_lib.AddImport(core_lib);

+ Library::InitMathLibrary(isolate);

+ const Library& math_lib = Library::Handle(Library::MathLibrary());

+ core_lib.AddImport(math_lib);

+ core_impl_lib.AddImport(math_lib);

isolate->object_store()->set_root_library(Library::Handle());

// Hook up predefined classes without setting their library pointers. These

« no previous file with comments | « runtime/lib/string.dart ('k') | samples/calculator/calculator.dart » ('j') | no next file with comments »