runtime/bin/http_parser.dart - Issue 10829459: Deprecate Math object in corelib in favor of dart:math library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/http_parser.dart

Issue 10829459: Deprecate Math object in corelib in favor of dart:math library. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address review comments. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/http_parser.dart

diff --git a/runtime/bin/http_parser.dart b/runtime/bin/http_parser.dart

index 95bdb1c9610dcdf6ef1cd5e965c9843c383fcb66..b5d1fe68b19bf4a4cb9867e4900eb8ed03a2726f 100644

--- a/runtime/bin/http_parser.dart

+++ b/runtime/bin/http_parser.dart

@@ -313,7 +313,7 @@ class _HttpParser {

case _State.RESPONSE_LINE_ENDING:

_expect(byte, _CharCode.LF);

_messageType == _MessageType.RESPONSE;

- int statusCode = Math.parseInt(_method_or_status_code.toString());

+ int statusCode = parseInt(_method_or_status_code.toString());

if (statusCode < 100 || statusCode > 599) {

throw new HttpParserException("Invalid response status code");

} else {

@@ -383,7 +383,7 @@ class _HttpParser {

if (headerField == "content-length" && !_chunked) {

// Ignore the Content-Length header if Transfer-Encoding

// is chunked (RFC 2616 section 4.4)

- _contentLength = Math.parseInt(headerValue);

+ _contentLength = parseInt(headerValue);

} else if (headerField == "connection") {

List<String> tokens = _tokenizeFieldValue(headerValue);

for (int i = 0; i < tokens.length; i++) {

« no previous file with comments | « runtime/bin/http_impl.dart ('k') | runtime/bin/http_utils.dart » ('j') | no next file with comments »