lib/compiler/implementation/util/uri_extras.dart - Issue 10829459: Deprecate Math object in corelib in favor of dart:math library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/util/uri_extras.dart

Issue 10829459: Deprecate Math object in corelib in favor of dart:math library. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address review comments. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/compiler/implementation/util/uri_extras.dart

diff --git a/lib/compiler/implementation/util/uri_extras.dart b/lib/compiler/implementation/util/uri_extras.dart

index d5e9a8fdbdd2e7f79962fcc84ae99dd0f6a2e350..9a57d983933c571ded1c9f59620a8adbf6a5f065 100644

--- a/lib/compiler/implementation/util/uri_extras.dart

+++ b/lib/compiler/implementation/util/uri_extras.dart

@@ -4,6 +4,7 @@

#library('uri_extras');

+#import('dart:math');

#import('dart:uri');

String relativize(Uri base, Uri uri) {

@@ -19,7 +20,7 @@ String relativize(Uri base, Uri uri) {

List<String> uriParts = uri.path.split('/');

List<String> baseParts = base.path.split('/');

int common = 0;

- int length = Math.min(uriParts.length, baseParts.length);

+ int length = min(uriParts.length, baseParts.length);

while (common < length && uriParts[common] == baseParts[common]) {

common++;

}

« no previous file with comments | « lib/compiler/implementation/tree/tree.dart ('k') | lib/crypto/crypto.dart » ('j') | no next file with comments »