Issue 10806016: Cleanup queryAll to return List<Element>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10806016: Cleanup queryAll to return List<Element>. (Closed)

Created:
8 years, 5 months ago by vsm

Modified:
8 years, 5 months ago

Reviewers:
sra1

CC:
reviews_dartlang.org, sethladd

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Cleanup queryAll to return List<Element>. BUG=3867 TEST=html/queryall-test.dart Committed: https://code.google.com/p/dart/source/detail?r=9784

Patch Set 1 #

Patch Set 2 : Fix test #

Patch Set 3 : More cleanup #

Patch Set 4 : Regen dart:html #

Patch Set 5 : Update Dromaeo sample #

Total comments: 1

Patch Set 6 : Fix comment #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+124 lines, -34 lines)			Patch
M	lib/dom/templates/html/impl/impl_Document.darttemplate	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/dom/templates/html/impl/impl_DocumentFragment.darttemplate	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/dom/templates/html/impl/impl_Element.darttemplate	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/dom/templates/html/interface/interface_Element.darttemplate	View	1 2 3 4 5	2 chunks	+7 lines, -2 lines	0 comments	Download
M	lib/dom/templates/html/interface/interface_NodeSelector.darttemplate	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View		5 chunks	+10 lines, -5 lines	0 comments	Download
M	lib/html/frog/html_frog.dart	View		5 chunks	+10 lines, -5 lines	0 comments	Download
M	samples/third_party/dromaeo/tests/dom-query-dom.dart	View	1 2 3 4	1 chunk	+6 lines, -6 lines	0 comments	Download
M	samples/third_party/dromaeo/tests/dom-query-html.dart	View	1 2 3 4	1 chunk	+6 lines, -6 lines	0 comments	Download
M	samples/third_party/dromaeo/tests/dom-query-htmlidiomatic.dart	View	1 2 3 4	1 chunk	+6 lines, -6 lines	0 comments	Download
A	tests/html/queryall_test.dart	View	1 2	1 chunk	+75 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sra1

8 years, 5 months ago (2012-07-19 00:44:00 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10806016/diff/2002/lib/dom/templates/h...
File lib/dom/templates/html/interface/interface_Element.darttemplate (right):

https://chromiumcodereview.appspot.com/10806016/diff/2002/lib/dom/templates/h...
lib/dom/templates/html/interface/interface_Element.darttemplate:9: // Note,
ElementList implements List so that it's implementing classes
Not sure I follow.

ElementList extends raw List so that classes implementing ElementList may be
cast to List<? extends Element>.


So why not declare 
interface ElementList extends List<? extends Element> ... 
?

Expand Messages | Collapse Messages