Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: lib/html/dartium/html_dartium.dart

Side-by-side diff isn't available for this file because of its large size.
Issue 10806016: Cleanup queryAll to return List<Element>. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix comment Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « lib/dom/templates/html/interface/interface_NodeSelector.darttemplate ('k') | lib/html/frog/html_frog.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/html/dartium/html_dartium.dart
diff --git a/lib/html/dartium/html_dartium.dart b/lib/html/dartium/html_dartium.dart
index 913b2bb006b43bb0f0776577f3bc18980d6c3001..4cf220415832bdf7d6db6ea1cf52b6ec4b1c1fbe 100644
--- a/lib/html/dartium/html_dartium.dart
+++ b/lib/html/dartium/html_dartium.dart
@@ -5987,7 +5987,7 @@ class _DocumentFragmentImpl extends _NodeImpl implements DocumentFragment {
_ElementImpl query(String selectors) => $dom_querySelector(selectors);
- ElementList queryAll(String selectors) =>
+ List<Element> queryAll(String selectors) =>
new _FrozenElementList._wrap($dom_querySelectorAll(selectors));
String get innerHTML() {
@@ -6423,7 +6423,7 @@ class _DocumentImpl extends _NodeImpl implements Document
return $dom_querySelector(selectors);
}
- ElementList queryAll(String selectors) {
+ List<Element> queryAll(String selectors) {
if (const RegExp("""^\\[name=["'][^'"]+['"]\\]\$""").hasMatch(selectors)) {
final mutableMatches = $dom_getElementsByName(
selectors.substring(7,selectors.length - 2));
@@ -7280,7 +7280,7 @@ class _ElementImpl extends _NodeImpl implements Element {
_ElementImpl query(String selectors) => $dom_querySelector(selectors);
- ElementList queryAll(String selectors) =>
+ List<Element> queryAll(String selectors) =>
new _FrozenElementList._wrap($dom_querySelectorAll(selectors));
_CssClassSet get classes() => new _CssClassSet(this);
@@ -27042,7 +27042,12 @@ interface EXTTextureFilterAnisotropic {
// WARNING: Do not edit - generated code.
-interface ElementList extends List<Element> {
+// TODO(vsm): Eliminate this type.
+
+// Note, ElementList implements List (instead of List<Element>) so
+// that its implementing classes may be cast to Lists of more specific
+// type such as List<CanvasElement>.
+interface ElementList extends List {
// TODO(jacobr): add element batch manipulation methods.
ElementList filter(bool f(Element element));
@@ -27077,7 +27082,7 @@ interface ElementRect {
interface NodeSelector {
Element query(String selectors);
- NodeList queryAll(String selectors);
+ List<Element> queryAll(String selectors);
}
/// @domName Element
« no previous file with comments | « lib/dom/templates/html/interface/interface_NodeSelector.darttemplate ('k') | lib/html/frog/html_frog.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698