Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: lib/html/frog/html_frog.dart

Side-by-side diff isn't available for this file because of its large size.
Issue 10806016: Cleanup queryAll to return List<Element>. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix comment Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « lib/html/dartium/html_dartium.dart ('k') | samples/third_party/dromaeo/tests/dom-query-dom.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/html/frog/html_frog.dart
diff --git a/lib/html/frog/html_frog.dart b/lib/html/frog/html_frog.dart
index 0d398910f3a4719a2de025078bebedf6116c3e75..34edfaccb785d34858d27edf42c5be47a6e4317c 100644
--- a/lib/html/frog/html_frog.dart
+++ b/lib/html/frog/html_frog.dart
@@ -4864,7 +4864,7 @@ class _DocumentImpl extends _NodeImpl implements Document
return $dom_querySelector(selectors);
}
- ElementList queryAll(String selectors) {
+ List<Element> queryAll(String selectors) {
if (const RegExp("""^\\[name=["'][^'"]+['"]\\]\$""").hasMatch(selectors)) {
final mutableMatches = $dom_getElementsByName(
selectors.substring(7,selectors.length - 2));
@@ -5138,7 +5138,7 @@ class _DocumentFragmentImpl extends _NodeImpl implements DocumentFragment native
_ElementImpl query(String selectors) => $dom_querySelector(selectors);
- ElementList queryAll(String selectors) =>
+ List<Element> queryAll(String selectors) =>
new _FrozenElementList._wrap($dom_querySelectorAll(selectors));
String get innerHTML() {
@@ -6062,7 +6062,7 @@ class _ElementImpl extends _NodeImpl implements Element native "*Element" {
_ElementImpl query(String selectors) => $dom_querySelector(selectors);
- ElementList queryAll(String selectors) =>
+ List<Element> queryAll(String selectors) =>
new _FrozenElementList._wrap($dom_querySelectorAll(selectors));
_CssClassSet get classes() => new _CssClassSet(this);
@@ -23118,7 +23118,12 @@ interface EXTTextureFilterAnisotropic {
// WARNING: Do not edit - generated code.
-interface ElementList extends List<Element> {
+// TODO(vsm): Eliminate this type.
+
+// Note, ElementList implements List (instead of List<Element>) so
+// that its implementing classes may be cast to Lists of more specific
+// type such as List<CanvasElement>.
+interface ElementList extends List {
// TODO(jacobr): add element batch manipulation methods.
ElementList filter(bool f(Element element));
@@ -23153,7 +23158,7 @@ interface ElementRect {
interface NodeSelector {
Element query(String selectors);
- NodeList queryAll(String selectors);
+ List<Element> queryAll(String selectors);
}
/// @domName Element
« no previous file with comments | « lib/html/dartium/html_dartium.dart ('k') | samples/third_party/dromaeo/tests/dom-query-dom.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698