Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Unified Diff: samples/third_party/dromaeo/tests/dom-query-dom.dart

Issue 10806016: Cleanup queryAll to return List<Element>. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix comment Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/html/frog/html_frog.dart ('k') | samples/third_party/dromaeo/tests/dom-query-html.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: samples/third_party/dromaeo/tests/dom-query-dom.dart
diff --git a/samples/third_party/dromaeo/tests/dom-query-dom.dart b/samples/third_party/dromaeo/tests/dom-query-dom.dart
index 25e961eeea0460d8e2b78885e3bec25225f232f1..8282bfcc8386928a6aea763ff2d2e84907ce9ee9 100644
--- a/samples/third_party/dromaeo/tests/dom-query-dom.dart
+++ b/samples/third_party/dromaeo/tests/dom-query-dom.dart
@@ -50,37 +50,37 @@ void main() {
})
.test('getElementsByTagName(div)', () {
for (int i = 0; i < num; i++) {
- NodeList elems = document.getElementsByTagName('div');
+ List<Element> elems = document.getElementsByTagName('div');
ret = elems[elems.length-1].nodeType;
}
})
.test('getElementsByTagName(p)', () {
for (int i = 0; i < num; i++) {
- NodeList elems = document.getElementsByTagName('p');
+ List<Element> elems = document.getElementsByTagName('p');
ret = elems[elems.length-1].nodeType;
}
})
.test('getElementsByTagName(a)', () {
for (int i = 0; i < num; i++) {
- NodeList elems = document.getElementsByTagName('a');
+ List<Element> elems = document.getElementsByTagName('a');
ret = elems[elems.length-1].nodeType;
}
})
.test('getElementsByTagName(*)', () {
for (int i = 0; i < num; i++) {
- NodeList elems = document.getElementsByTagName('*');
+ List<Element> elems = document.getElementsByTagName('*');
ret = elems[elems.length-1].nodeType;
}
})
.test('getElementsByTagName (not in document)', () {
for (int i = 0; i < num; i++) {
- NodeList elems = document.getElementsByTagName('strong');
+ List<Element> elems = document.getElementsByTagName('strong');
ret = elems.length == 0;
}
})
.test('getElementsByName', () {
for (int i = 0; i < num * 20; i++) {
- NodeList elems = document.getElementsByName('test$num');
+ List<Element> elems = document.getElementsByName('test$num');
ret = elems[elems.length-1].nodeType;
elems = document.getElementsByName('test$num');
ret = elems[elems.length-1].nodeType;
« no previous file with comments | « lib/html/frog/html_frog.dart ('k') | samples/third_party/dromaeo/tests/dom-query-html.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698