Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Unified Diff: lib/dom/templates/html/interface/interface_Element.darttemplate

Issue 10806016: Cleanup queryAll to return List<Element>. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix comment Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/dom/templates/html/interface/interface_Element.darttemplate
diff --git a/lib/dom/templates/html/interface/interface_Element.darttemplate b/lib/dom/templates/html/interface/interface_Element.darttemplate
index dee20666cd9a71ed1f525cdd3d26dba62082bfaf..455eb0d24f804990c5402ad2773a97dca3bd0125 100644
--- a/lib/dom/templates/html/interface/interface_Element.darttemplate
+++ b/lib/dom/templates/html/interface/interface_Element.darttemplate
@@ -4,7 +4,12 @@
// WARNING: Do not edit - generated code.
-interface ElementList extends List<Element> {
+// TODO(vsm): Eliminate this type.
+
+// Note, ElementList implements List (instead of List<Element>) so
+// that its implementing classes may be cast to Lists of more specific
+// type such as List<CanvasElement>.
+interface ElementList extends List {
// TODO(jacobr): add element batch manipulation methods.
ElementList filter(bool f(Element element));
@@ -39,7 +44,7 @@ interface ElementRect {
interface NodeSelector {
Element query(String selectors);
- NodeList queryAll(String selectors);
+ List<Element> queryAll(String selectors);
}
$!COMMENT

Powered by Google App Engine
This is Rietveld 408576698