Minimize uses of lazy initialization by adding explicit initialization functions.

Minimize uses of lazy initialization by adding explicit initialization functions.

BUG=118686
Committed: https://code.google.com/p/v8/source/detail?r=11239

[danno, 2012-04-04 20:47:56]

https://chromiumcodereview.appspot.com/9976003/diff/1/src/frames.cc
File src/frames.cc (right):

https://chromiumcodereview.appspot.com/9976003/diff/1/src/frames.cc#newcode1372
src/frames.cc:1372: void Init() {
How about putting this directly in SetUpJSCallerSavedCodeData? I don't see the
need for the function on the struct any more.

https://chromiumcodereview.appspot.com/9976003/diff/1/src/platform-macos.cc
File src/platform-macos.cc (right):

https://chromiumcodereview.appspot.com/9976003/diff/1/src/platform-macos.cc#n...
src/platform-macos.cc:881: }
Can you please move these back to where they use to be in the file? It makes the
diff shorter and the change more compact. Also applies to other platform files.

https://chromiumcodereview.appspot.com/9976003/diff/1/src/v8.cc
File src/v8.cc (right):

https://chromiumcodereview.appspot.com/9976003/diff/1/src/v8.cc#newcode279
src/v8.cc:279: SamplerRegistry::GlobalSetUp();
nit: Perhaps just SetUp rather than GlobalSetUp, since all of the other methods
of the same kind use that convention.

https://chromiumcodereview.appspot.com/9976003/diff/1/src/v8.cc#newcode280
src/v8.cc:280: ExternalReference::GlobalSetUp();
Same here

https://chromiumcodereview.appspot.com/9976003/diff/1/src/x64/disasm-x64.cc
File src/x64/disasm-x64.cc (right):

https://chromiumcodereview.appspot.com/9976003/diff/1/src/x64/disasm-x64.cc#n...
src/x64/disasm-x64.cc:348: const InstructionTable& instruction_table_;
We don't use const references in V8. Please use const *.

[Philippe, 2012-04-05 11:30:18]

https://chromiumcodereview.appspot.com/9976003/diff/1/src/frames.cc
File src/frames.cc (right):

https://chromiumcodereview.appspot.com/9976003/diff/1/src/frames.cc#newcode1372
src/frames.cc:1372: void Init() {
On 2012/04/04 20:47:57, danno wrote:
> How about putting this directly in SetUpJSCallerSavedCodeData? I don't see the
> need for the function on the struct any more.

Done.

https://chromiumcodereview.appspot.com/9976003/diff/1/src/platform-macos.cc
File src/platform-macos.cc (right):

https://chromiumcodereview.appspot.com/9976003/diff/1/src/platform-macos.cc#n...
src/platform-macos.cc:881: }
On 2012/04/04 20:47:57, danno wrote:
> Can you please move these back to where they use to be in the file? It makes
the
> diff shorter and the change more compact. Also applies to other platform
files.

I had unfortunately to move this function here to make it be declared after the
SamplerThread class which it uses (SamplerThread::SetUp()). We have to move
either OS::SetUp() or SamplerThread.

https://chromiumcodereview.appspot.com/9976003/diff/1/src/v8.cc
File src/v8.cc (right):

https://chromiumcodereview.appspot.com/9976003/diff/1/src/v8.cc#newcode279
src/v8.cc:279: SamplerRegistry::GlobalSetUp();
On 2012/04/04 20:47:57, danno wrote:
> nit: Perhaps just SetUp rather than GlobalSetUp, since all of the other
methods
> of the same kind use that convention. 

Done.

https://chromiumcodereview.appspot.com/9976003/diff/1/src/v8.cc#newcode280
src/v8.cc:280: ExternalReference::GlobalSetUp();
On 2012/04/04 20:47:57, danno wrote:
> Same here

Done.

https://chromiumcodereview.appspot.com/9976003/diff/1/src/x64/disasm-x64.cc
File src/x64/disasm-x64.cc (right):

https://chromiumcodereview.appspot.com/9976003/diff/1/src/x64/disasm-x64.cc#n...
src/x64/disasm-x64.cc:348: const InstructionTable& instruction_table_;
On 2012/04/04 20:47:57, danno wrote:
> We don't use const references in V8. Please use const *. 

Done.

https://chromiumcodereview.appspot.com/9976003/diff/14003/src/v8.cc
File src/v8.cc (right):

https://chromiumcodereview.appspot.com/9976003/diff/14003/src/v8.cc#newcode267
src/v8.cc:267: RuntimeProfiler::GlobalSetUp();
For this one, we have to keep it as GlobalSetUp() since RuntimeProfiler already
contains a non-static SetUp() method. I have just made it "GlobalSetUp" instead
of "GlobalSetup" for consistency with the other ones.

[danno, 2012-04-05 14:07:03]

LGTM, I'll land it.