Minimize uses of lazy initialization by adding explicit initialization functions.

src/frames.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1351 matching lines @@
   int n = 0;
   while (reglist != 0) {
     n++;
     reglist &= reglist - 1;  // clear one bit
   }
   return n;
 }
 
 
 struct JSCallerSavedCodeData {
-  JSCallerSavedCodeData() {
+  void Init() {

[danno, 2012/04/04 20:47:57]

How about putting this directly in SetUpJSCallerSavedCodeData? I don't see the
need for the function on the struct any more.

[Philippe, 2012/04/05 11:30:18]

Done.

     int i = 0;
     for (int r = 0; r < kNumRegs; r++)
       if ((kJSCallerSaved & (1 << r)) != 0)
         reg_code[i++] = r;
 
     ASSERT(i == kNumJSCallerSaved);
   }
   int reg_code[kNumJSCallerSaved];
 };
 
+JSCallerSavedCodeData caller_saved_code_data;
 
-static LazyInstance<JSCallerSavedCodeData>::type caller_saved_code_data =
-    LAZY_INSTANCE_INITIALIZER;
+void SetUpJSCallerSavedCodeData() {
+  caller_saved_code_data.Init();
+}
 
 int JSCallerSavedCode(int n) {
   ASSERT(0 <= n && n < kNumJSCallerSaved);
-  return caller_saved_code_data.Get().reg_code[n];
+  return caller_saved_code_data.reg_code[n];
 }
 
 
 #define DEFINE_WRAPPER(type, field)                              \
 class field##_Wrapper : public ZoneObject {                      \
  public:  /* NOLINT */                                           \
   field##_Wrapper(const field& original) : frame_(original) {    \
   }                                                              \
   field frame_;                                                  \
 };
@@ skipping 20 matching lines @@
   ZoneList<StackFrame*> list(10);
   for (StackFrameIterator it; !it.done(); it.Advance()) {
     StackFrame* frame = AllocateFrameCopy(it.frame());
     list.Add(frame);
   }
   return list.ToVector();
 }
 
 
 } }  // namespace v8::internal