Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Unified Diff: chrome/browser/ui/cocoa/first_run_bubble_controller.mm

Issue 9969141: Add FirstRun.SearchEngineBubble UMA histogram counts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Use a histogram instead; also count impressions. Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/first_run/first_run.h ('k') | chrome/browser/ui/gtk/first_run_bubble.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/first_run_bubble_controller.mm
diff --git a/chrome/browser/ui/cocoa/first_run_bubble_controller.mm b/chrome/browser/ui/cocoa/first_run_bubble_controller.mm
index 26ac64e5982e56055b0563ec264f0f02c7a168ed..aa727a20d2b7e8766e0f95fc2984ee0c2b3c6179 100644
--- a/chrome/browser/ui/cocoa/first_run_bubble_controller.mm
+++ b/chrome/browser/ui/cocoa/first_run_bubble_controller.mm
@@ -5,7 +5,9 @@
#import "chrome/browser/ui/cocoa/first_run_bubble_controller.h"
#include "base/logging.h"
+#include "base/metrics/histogram.h"
#include "base/utf_string_conversions.h"
+#include "chrome/browser/first_run/first_run.h"
#include "chrome/browser/search_engines/util.h"
#include "chrome/browser/ui/browser_list.h"
#import "chrome/browser/ui/cocoa/l10n_util.h"
@@ -51,6 +53,10 @@
}
- (void)awakeFromNib {
+ HISTOGRAM_ENUMERATION("FirstRun.SearchEngineBubble",
Ilya Sherman 2012/04/04 23:28:35 This should be an UMA_HISTOGRAM_ENUMERATION, so th
msw 2012/04/04 23:50:40 Done.
+ first_run::FIRST_RUN_BUBBLE_SHOWN,
+ first_run::NUM_FIRST_RUN_BUBBLE_METRICS);
+
DCHECK(header_);
[header_ setStringValue:cocoa_l10n_util::ReplaceNSStringPlaceholders(
[header_ stringValue], GetDefaultSearchEngineName(profile_), NULL)];
@@ -81,6 +87,10 @@
}
- (IBAction)onChange:(id)sender {
+ HISTOGRAM_ENUMERATION("FirstRun.SearchEngineBubble",
Ilya Sherman 2012/04/04 23:28:35 nit: I would recommend having a single LogFirstRun
msw 2012/04/04 23:50:40 Done.
+ first_run::FIRST_RUN_BUBBLE_CHANGE_SEARCH_INVOKED,
+ first_run::NUM_FIRST_RUN_BUBBLE_METRICS);
+
Browser* browser = BrowserList::GetLastActiveWithProfile(profile_);
[self close];
if (browser)
« no previous file with comments | « chrome/browser/first_run/first_run.h ('k') | chrome/browser/ui/gtk/first_run_bubble.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698