Add FirstRun.SearchEngineBubble UMA histogram counts.

Add FirstRun.SearchEngineBubble UMA histogram counts.

Add an enum for first run bubble histogram counts.
Add first_run::LogFirstRunMetric utility function.
Log metrics for actions of interest (show and 'Change').

This change depends on the src-internal change (4219017).

BUG=121782
TEST=New histogram data available for first run bubble impressions and use.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=130848

[msw, 2012-04-04 23:21:49]

Hey Ilya, can you please take a look? Thanks!
Should I land this or the internal CL first?

[Ilya Sherman, 2012-04-04 23:28:34]

On 2012/04/04 23:21:49, msw wrote:
> Should I land this or the internal CL first?

Either order should be fine.

https://chromiumcodereview.appspot.com/9969141/diff/10001/chrome/browser/ui/c...
File chrome/browser/ui/cocoa/first_run_bubble_controller.mm (right):

https://chromiumcodereview.appspot.com/9969141/diff/10001/chrome/browser/ui/c...
chrome/browser/ui/cocoa/first_run_bubble_controller.mm:56:
HISTOGRAM_ENUMERATION("FirstRun.SearchEngineBubble",
This should be an UMA_HISTOGRAM_ENUMERATION, so that the data gets uploaded to
UMA (versus just collected locally).

https://chromiumcodereview.appspot.com/9969141/diff/10001/chrome/browser/ui/c...
chrome/browser/ui/cocoa/first_run_bubble_controller.mm:90:
HISTOGRAM_ENUMERATION("FirstRun.SearchEngineBubble",
nit: I would recommend having a single LogFirstRunMetric() function exposed,
perhaps in chrome/browser/first_run/first_run.h, so that there's no opportunity
for typos to creep into the histogram name.

[msw, 2012-04-04 23:50:40]

Good catch and great tip. Please take another look; thanks!

https://chromiumcodereview.appspot.com/9969141/diff/10001/chrome/browser/ui/c...
File chrome/browser/ui/cocoa/first_run_bubble_controller.mm (right):

https://chromiumcodereview.appspot.com/9969141/diff/10001/chrome/browser/ui/c...
chrome/browser/ui/cocoa/first_run_bubble_controller.mm:56:
HISTOGRAM_ENUMERATION("FirstRun.SearchEngineBubble",
On 2012/04/04 23:28:35, Ilya Sherman wrote:
> This should be an UMA_HISTOGRAM_ENUMERATION, so that the data gets uploaded to
> UMA (versus just collected locally).

Done.

https://chromiumcodereview.appspot.com/9969141/diff/10001/chrome/browser/ui/c...
chrome/browser/ui/cocoa/first_run_bubble_controller.mm:90:
HISTOGRAM_ENUMERATION("FirstRun.SearchEngineBubble",
On 2012/04/04 23:28:35, Ilya Sherman wrote:
> nit: I would recommend having a single LogFirstRunMetric() function exposed,
> perhaps in chrome/browser/first_run/first_run.h, so that there's no
opportunity
> for typos to creep into the histogram name.

Done.

[Ilya Sherman, 2012-04-05 00:02:38]

LGTM

[commit-bot: I haz the power, 2012-04-05 00:09:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/9969141/12002

[commit-bot: I haz the power, 2012-04-05 00:09:16]

Presubmit check for 9969141-12002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/ui/gtk
    chrome/browser/ui

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[msw, 2012-04-05 00:10:39]

+sky for OWNERS. PTAL, thanks!

[sky, 2012-04-05 03:50:03]

LGTM

[commit-bot: I haz the power, 2012-04-05 04:02:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/9969141/12002

[commit-bot: I haz the power, 2012-04-05 07:10:40]

Change committed as 130848