Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Unified Diff: chrome/browser/ui/gtk/first_run_bubble.cc

Issue 9969141: Add FirstRun.SearchEngineBubble UMA histogram counts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Use a histogram instead; also count impressions. Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/gtk/first_run_bubble.cc
diff --git a/chrome/browser/ui/gtk/first_run_bubble.cc b/chrome/browser/ui/gtk/first_run_bubble.cc
index d1bbeb6739a65b06cd3b7b9d19a7a363e0d12aaf..badc294034d6fb34693e0b136fb406e813a68249 100644
--- a/chrome/browser/ui/gtk/first_run_bubble.cc
+++ b/chrome/browser/ui/gtk/first_run_bubble.cc
@@ -7,7 +7,9 @@
#include <gtk/gtk.h>
#include "base/i18n/rtl.h"
+#include "base/metrics/histogram.h"
#include "base/utf_string_conversions.h"
+#include "chrome/browser/first_run/first_run.h"
#include "chrome/browser/search_engines/util.h"
#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/gtk/theme_service_gtk.h"
@@ -31,6 +33,10 @@ const int kInterLineSpacing = 5;
void FirstRunBubble::Show(Profile* profile,
GtkWidget* anchor,
const gfx::Rect& rect) {
+ HISTOGRAM_ENUMERATION("FirstRun.SearchEngineBubble",
+ first_run::FIRST_RUN_BUBBLE_SHOWN,
+ first_run::NUM_FIRST_RUN_BUBBLE_METRICS);
+
new FirstRunBubble(profile, anchor, rect);
}
@@ -83,6 +89,10 @@ void FirstRunBubble::HandleDestroy(GtkWidget* sender) {
}
void FirstRunBubble::HandleChangeLink(GtkWidget* sender) {
+ HISTOGRAM_ENUMERATION("FirstRun.SearchEngineBubble",
+ first_run::FIRST_RUN_BUBBLE_CHANGE_SEARCH_INVOKED,
+ first_run::NUM_FIRST_RUN_BUBBLE_METRICS);
+
// Get |profile_|'s browser before closing the bubble, which deletes |this|.
Browser* browser = BrowserList::GetLastActiveWithProfile(profile_);
bubble_->Close();

Powered by Google App Engine
This is Rietveld 408576698