Add FirstRun.SearchEngineBubble UMA histogram counts.

chrome/browser/ui/cocoa/first_run_bubble_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/first_run_bubble_controller.h"
 
 #include "base/logging.h"
+#include "base/metrics/histogram.h"
 #include "base/utf_string_conversions.h"
+#include "chrome/browser/first_run/first_run.h"
 #include "chrome/browser/search_engines/util.h"
 #include "chrome/browser/ui/browser_list.h"
 #import "chrome/browser/ui/cocoa/l10n_util.h"
 #import "chrome/browser/ui/cocoa/info_bubble_view.h"
 #include "grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 
 @interface FirstRunBubbleController(Private)
 - (id)initRelativeToView:(NSView*)view
                   offset:(NSPoint)offset
@@ skipping 25 matching lines @@
     // the omnibox. This happens if the bubble never became key, due to it
     // showing up so early in the startup sequence. As a workaround, close it
     // automatically after a few seconds if it doesn't become key.
     // http://crbug.com/52726
     [self performSelector:@selector(closeIfNotKey) withObject:nil afterDelay:3];
   }
   return self;
 }
 
 - (void)awakeFromNib {
+  HISTOGRAM_ENUMERATION("FirstRun.SearchEngineBubble",

[Ilya Sherman, 2012/04/04 23:28:35]

This should be an UMA_HISTOGRAM_ENUMERATION, so that the data gets uploaded to
UMA (versus just collected locally).

[msw, 2012/04/04 23:50:40]

Done.

+                        first_run::FIRST_RUN_BUBBLE_SHOWN,
+                        first_run::NUM_FIRST_RUN_BUBBLE_METRICS);
+
   DCHECK(header_);
   [header_ setStringValue:cocoa_l10n_util::ReplaceNSStringPlaceholders(
       [header_ stringValue], GetDefaultSearchEngineName(profile_), NULL)];
 
   // Adapt window size to contents. Do this before all other layouting.
   CGFloat dy = cocoa_l10n_util::VerticallyReflowGroup([[self bubble] subviews]);
   NSSize ds = NSMakeSize(0, dy);
   ds = [[self bubble] convertSize:ds toView:nil];
 
   NSRect frame = [[self window] frame];
@@ skipping 10 matching lines @@
                                              object:nil];
   [super close];
 }
 
 - (void)closeIfNotKey {
   if (![[self window] isKeyWindow])
     [self close];
 }
 
 - (IBAction)onChange:(id)sender {
+  HISTOGRAM_ENUMERATION("FirstRun.SearchEngineBubble",

[Ilya Sherman, 2012/04/04 23:28:35]

nit: I would recommend having a single LogFirstRunMetric() function exposed,
perhaps in chrome/browser/first_run/first_run.h, so that there's no opportunity
for typos to creep into the histogram name.

[msw, 2012/04/04 23:50:40]

Done.

+                        first_run::FIRST_RUN_BUBBLE_CHANGE_SEARCH_INVOKED,
+                        first_run::NUM_FIRST_RUN_BUBBLE_METRICS);
+
   Browser* browser = BrowserList::GetLastActiveWithProfile(profile_);
   [self close];
   if (browser)
     browser->OpenSearchEngineOptionsDialog();
 }
 
 @end  // FirstRunBubbleController