Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1107)

Unified Diff: chrome/browser/ui/views/first_run_bubble.cc

Issue 9969141: Add FirstRun.SearchEngineBubble UMA histogram counts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add and use first_run::LogFirstRunMetric; fix UMA macro. Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/gtk/first_run_bubble.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/first_run_bubble.cc
diff --git a/chrome/browser/ui/views/first_run_bubble.cc b/chrome/browser/ui/views/first_run_bubble.cc
index 912b6408ad1aa7ff0f26f18808733a726273b9e8..749e6d3da6e6ef778cd4c74d810ed399f2cb6f55 100644
--- a/chrome/browser/ui/views/first_run_bubble.cc
+++ b/chrome/browser/ui/views/first_run_bubble.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/ui/views/first_run_bubble.h"
#include "base/utf_string_conversions.h"
+#include "chrome/browser/first_run/first_run.h"
#include "chrome/browser/search_engines/util.h"
#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/views/window.h"
@@ -31,6 +32,8 @@ namespace first_run {
// static
FirstRunBubble* FirstRunBubble::ShowBubble(Profile* profile,
views::View* anchor_view) {
+ first_run::LogFirstRunMetric(first_run::FIRST_RUN_BUBBLE_SHOWN);
+
FirstRunBubble* delegate = new FirstRunBubble(profile, anchor_view);
browser::CreateViewsBubble(delegate);
delegate->StartFade(true);
@@ -90,6 +93,8 @@ FirstRunBubble::~FirstRunBubble() {
}
void FirstRunBubble::LinkClicked(views::Link* source, int event_flags) {
+ first_run::LogFirstRunMetric(first_run::FIRST_RUN_BUBBLE_CHANGE_INVOKED);
+
// Get |profile_|'s browser before closing the bubble, which deletes |this|.
Browser* browser = BrowserList::GetLastActiveWithProfile(profile_);
GetWidget()->Close();
« no previous file with comments | « chrome/browser/ui/gtk/first_run_bubble.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698