ninja windows: suppress 'Creating library...' output

ninja windows: suppress 'Creating library...' output

A common noisy message that messes with one-line-ninja-overprinting style.

R=thakis@chromium.org

Committed: https://code.google.com/p/gyp/source/detail?r=1299

[Nico, 2012-04-03 23:00:38]

lgtm

Oh, does ninja do overwriting output on windows already? cool :-)

http://chromiumcodereview.appspot.com/9969078/diff/1/pylib/gyp/generator/ninj...
File pylib/gyp/generator/ninja.py (right):

http://chromiumcodereview.appspot.com/9969078/diff/1/pylib/gyp/generator/ninj...
pylib/gyp/generator/ninja.py:1215: dllcmd = ('python gyp-win-tool
link-suppress-import-lib-name '
nit: i'd just call this link-wrapper, then it can learn new tricks without you
having to rename it

http://chromiumcodereview.appspot.com/9969078/diff/1/pylib/gyp/win_tool.py
File pylib/gyp/win_tool.py (right):

http://chromiumcodereview.appspot.com/9969078/diff/1/pylib/gyp/win_tool.py#ne...
pylib/gyp/win_tool.py:61: out, _ = popen.communicate()
nit:

for line in out:
  if not line.startswith('    Creating library'):
    sys.stdout.write(line)

is faster to read, faster to execute, and the same number of lines

[scottmg, 2012-04-03 23:09:43]

On 2012/04/03 23:00:38, Nico wrote:
> lgtm
> 
> Oh, does ninja do overwriting output on windows already? cool :-)

Yup, upstreamed even. Evan said it couldn't be called "ninja" until it did. ;)

> 
>
http://chromiumcodereview.appspot.com/9969078/diff/1/pylib/gyp/generator/ninj...
> File pylib/gyp/generator/ninja.py (right):
> 
>
http://chromiumcodereview.appspot.com/9969078/diff/1/pylib/gyp/generator/ninj...
> pylib/gyp/generator/ninja.py:1215: dllcmd = ('python gyp-win-tool
> link-suppress-import-lib-name '
> nit: i'd just call this link-wrapper, then it can learn new tricks without you
> having to rename it

Done.

> 
> http://chromiumcodereview.appspot.com/9969078/diff/1/pylib/gyp/win_tool.py
> File pylib/gyp/win_tool.py (right):
> 
>
http://chromiumcodereview.appspot.com/9969078/diff/1/pylib/gyp/win_tool.py#ne...
> pylib/gyp/win_tool.py:61: out, _ = popen.communicate()
> nit:
> 
> for line in out:
>   if not line.startswith('    Creating library'):
>     sys.stdout.write(line)
> 
> is faster to read, faster to execute, and the same number of lines

Much better, thanks, done.

[Nico, 2012-04-03 23:13:12]

http://chromiumcodereview.appspot.com/9969078/diff/4002/pylib/gyp/win_tool.py
File pylib/gyp/win_tool.py (right):

http://chromiumcodereview.appspot.com/9969078/diff/4002/pylib/gyp/win_tool.py...
pylib/gyp/win_tool.py:62: for line in out.splitlines():
You can just iterate over popen.stdout, which will yield the output in line form
i think. (and when you're done reading, popen.returncode is ready.) at least
that works on posix.

[scottmg, 2012-04-03 23:29:41]

On 2012/04/03 23:13:12, Nico wrote:
> http://chromiumcodereview.appspot.com/9969078/diff/4002/pylib/gyp/win_tool.py
> File pylib/gyp/win_tool.py (right):
> 
>
http://chromiumcodereview.appspot.com/9969078/diff/4002/pylib/gyp/win_tool.py...
> pylib/gyp/win_tool.py:62: for line in out.splitlines():
> You can just iterate over popen.stdout, which will yield the output in line
form
> i think. (and when you're done reading, popen.returncode is ready.) at least
> that works on posix.

Indeed, just like magic. I hastily committed already, so fix here: 
https://chromiumcodereview.appspot.com/9959128