Issue 9959128: ninja windows: simpler link-wrapper code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9959128: ninja windows: simpler link-wrapper code (Closed)

Created:
8 years, 8 months ago by scottmg

Modified:
8 years, 8 months ago

Reviewers:
Nico

CC:
gyp-developer_googlegroups.com

Base URL:
https://gyp.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

ninja windows: simpler link-wrapper code (already reviewed/suggested in previous CL) TBR=thakis@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1300

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	pylib/gyp/win_tool.py	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scottmg

8 years, 8 months ago (2012-04-04 00:53:55 UTC) #3

Hmm, apparently returncode isn't set, or at least there's a race (returncodes
are coming back wrong on bot e.g.
http://build.chromium.org/p/tryserver.nacl/builders/gyp-win64/builds/166/step...)

Popen.wait()ing for the rc says it could deadlock when redirecting, so I'm just
going to revert this change, and go back to communicate().
http://docs.python.org/library/subprocess.html#popen-objects

Expand Messages | Collapse Messages