Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Unified Diff: pylib/gyp/generator/ninja.py

Issue 9969078: ninja windows: suppress 'Creating library...' output (Closed) Base URL: https://gyp.googlecode.com/svn/trunk
Patch Set: fixes Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pylib/gyp/win_tool.py » ('j') | pylib/gyp/win_tool.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pylib/gyp/generator/ninja.py
diff --git a/pylib/gyp/generator/ninja.py b/pylib/gyp/generator/ninja.py
index a84bd5550712dfd1f0868adbf0a11865533fa2a6..5d8aea1e1496ccda0fcd974183b59c439f262d54 100644
--- a/pylib/gyp/generator/ninja.py
+++ b/pylib/gyp/generator/ninja.py
@@ -1212,8 +1212,9 @@ def GenerateOutputForConfig(target_list, target_dicts, data, params,
rspfile='$out.rsp',
rspfile_content='$in')
dlldesc = 'LINK(DLL) $dll and $implib'
- dllcmd = ('$ld /nologo /IMPLIB:$implib /DLL /OUT:$dll '
- '/PDB:$dll.pdb $libs @$dll.rsp $ldflags')
+ dllcmd = ('python gyp-win-tool link-wrapper '
+ '$ld /nologo /IMPLIB:$implib /DLL /OUT:$dll '
+ '/PDB:$dll.pdb $libs @$dll.rsp $ldflags')
master_ninja.rule('solink', description=dlldesc, command=dllcmd,
rspfile='$dll.rsp', rspfile_content='$in')
master_ninja.rule('solink_module', description=dlldesc, command=dllcmd,
@@ -1223,7 +1224,8 @@ def GenerateOutputForConfig(target_list, target_dicts, data, params,
master_ninja.rule(
'link',
description='LINK $out',
- command=('$ld /nologo /OUT:$out /PDB:$out.pdb $in $libs $ldflags'))
+ command=('python gyp-win-tool link-wrapper '
+ '$ld /nologo /OUT:$out /PDB:$out.pdb $in $libs $ldflags'))
else:
master_ninja.rule(
'objc',
« no previous file with comments | « no previous file | pylib/gyp/win_tool.py » ('j') | pylib/gyp/win_tool.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698