Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: chrome/browser/ui/panels/panel_browsertest.cc

Issue 9968078: Honor window size for chrome.windows.create when parent window is maximized. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove extraneous logging Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/panel_browsertest.cc
diff --git a/chrome/browser/ui/panels/panel_browsertest.cc b/chrome/browser/ui/panels/panel_browsertest.cc
index 6dd888348fe00128dbe78900ea156d353a6b961b..3988bf34815b90c931ea5ac49b60ee24c69606b1 100644
--- a/chrome/browser/ui/panels/panel_browsertest.cc
+++ b/chrome/browser/ui/panels/panel_browsertest.cc
@@ -1488,10 +1488,9 @@ class DownloadObserver : public content::DownloadManager::Observer {
IN_PROC_BROWSER_TEST_F(PanelDownloadTest, Download) {
Profile* profile = browser()->profile();
ASSERT_TRUE(CreateDownloadDirectory(profile));
- Browser* panel_browser = Browser::CreateForApp(Browser::TYPE_PANEL,
- "PanelTest",
- gfx::Rect(),
- profile);
+ Browser* panel_browser = Browser::CreateWithParams(
+ Browser::CreateParams::CreateForApp(
+ Browser::TYPE_PANEL, "PanelTest", gfx::Rect(), profile));
EXPECT_EQ(2U, BrowserList::size());
ASSERT_FALSE(browser()->window()->IsDownloadShelfVisible());
ASSERT_FALSE(panel_browser->window()->IsDownloadShelfVisible());
@@ -1542,10 +1541,9 @@ IN_PROC_BROWSER_TEST_F(PanelDownloadTest, Download) {
IN_PROC_BROWSER_TEST_F(PanelDownloadTest, MAYBE_DownloadNoTabbedBrowser) {
Profile* profile = browser()->profile();
ASSERT_TRUE(CreateDownloadDirectory(profile));
- Browser* panel_browser = Browser::CreateForApp(Browser::TYPE_PANEL,
- "PanelTest",
- gfx::Rect(),
- profile);
+ Browser* panel_browser = Browser::CreateWithParams(
+ Browser::CreateParams::CreateForApp(
+ Browser::TYPE_PANEL, "PanelTest", gfx::Rect(), profile));
EXPECT_EQ(2U, BrowserList::size());
ASSERT_FALSE(browser()->window()->IsDownloadShelfVisible());
ASSERT_FALSE(panel_browser->window()->IsDownloadShelfVisible());

Powered by Google App Engine
This is Rietveld 408576698