Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3439)

Unified Diff: chrome/browser/ui/browser_navigator_browsertest.cc

Issue 9968078: Honor window size for chrome.windows.create when parent window is maximized. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove extraneous logging Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_navigator_browsertest.cc
diff --git a/chrome/browser/ui/browser_navigator_browsertest.cc b/chrome/browser/ui/browser_navigator_browsertest.cc
index 3451f126ef1d5d4b64273e58c1eff8bfa7309b6d..d15f0250f977aa483efb7ac5873ade4596240cb1 100644
--- a/chrome/browser/ui/browser_navigator_browsertest.cc
+++ b/chrome/browser/ui/browser_navigator_browsertest.cc
@@ -63,15 +63,17 @@ browser::NavigateParams BrowserNavigatorTest::MakeNavigateParams(
Browser* BrowserNavigatorTest::CreateEmptyBrowserForType(Browser::Type type,
Profile* profile) {
- Browser* browser = Browser::CreateForType(type, profile);
+ Browser* browser = Browser::CreateWithParams(
+ Browser::CreateParams(type, profile));
browser->AddBlankTab(true);
return browser;
}
Browser* BrowserNavigatorTest::CreateEmptyBrowserForApp(Browser::Type type,
Profile* profile) {
- Browser* browser = Browser::CreateForApp(Browser::TYPE_POPUP, "Test",
- gfx::Rect(), profile);
+ Browser* browser = Browser::CreateWithParams(
+ Browser::CreateParams::CreateForApp(
+ Browser::TYPE_POPUP, "Test", gfx::Rect(), profile));
browser->AddBlankTab(true);
return browser;
}
@@ -1285,8 +1287,10 @@ IN_PROC_BROWSER_TEST_F(PanelBrowserNavigatorTest, NavigateFromCrashedPanel) {
GURL url2("http://maps.google.com/#b");
// Create a panel.
- Browser* panel_browser = Browser::CreateForApp(Browser::TYPE_PANEL,
- "Test", gfx::Rect(100, 100), browser()->profile());
+ Browser* panel_browser = Browser::CreateWithParams(
+ Browser::CreateParams::CreateForApp(
+ Browser::TYPE_PANEL, "Test", gfx::Rect(100, 100),
+ browser()->profile()));
// Navigate to the page.
browser::NavigateParams p(MakeNavigateParams(panel_browser));

Powered by Google App Engine
This is Rietveld 408576698