Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 987513006: Chromecast: fixes crash in AvPipelineImpl teardown. (Closed)

Created:
5 years, 9 months ago by gunsch
Modified:
5 years, 9 months ago
Reviewers:
lcwu1, servolk, erickung1
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chromecast: fixes crash in AvPipelineImpl teardown. (1) Making AvPipelineImpl ref-counted caused it to outlive some of its members, resulting in crashes. This is mitigated by introducing an explicit Finalize() API for {Audio,Video}PipelineImpl. (2) "Stop" message was not propagated to the browser-side pipeline at all. This is now called in ~CmaRenderer. R=lcwu@chromium.org,erickung@chromium.org,servolk@chromium.org BUG=internal b/19628205 Committed: https://crrev.com/d8f23a5a8450540db1145ee70591325de570d2cf Cr-Commit-Position: refs/heads/master@{#319453}

Patch Set 1 #

Patch Set 2 : update when Stop is called #

Patch Set 3 : changes Finalize signature (not a build failure on arm...) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -10 lines) Patch
M chromecast/media/cma/filters/cma_renderer.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chromecast/media/cma/pipeline/audio_pipeline_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chromecast/media/cma/pipeline/av_pipeline_impl.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chromecast/media/cma/pipeline/av_pipeline_impl.cc View 1 2 2 chunks +14 lines, -10 lines 0 comments Download
M chromecast/media/cma/pipeline/video_pipeline_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
gunsch
5 years, 9 months ago (2015-03-06 02:12:56 UTC) #1
lcwu1
lgtm
5 years, 9 months ago (2015-03-06 03:42:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/987513006/40001
5 years, 9 months ago (2015-03-06 15:59:06 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-06 16:18:40 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-06 16:19:24 UTC) #6
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d8f23a5a8450540db1145ee70591325de570d2cf
Cr-Commit-Position: refs/heads/master@{#319453}

Powered by Google App Engine
This is Rietveld 408576698