chromecast/media/cma/pipeline/av_pipeline_impl.h - Issue 987513006: Chromecast: fixes crash in AvPipelineImpl teardown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/media/cma/pipeline/av_pipeline_impl.h

Issue 987513006: Chromecast: fixes crash in AvPipelineImpl teardown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: changes Finalize signature (not a build failure on arm...) Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromecast/media/cma/pipeline/av_pipeline_impl.h

diff --git a/chromecast/media/cma/pipeline/av_pipeline_impl.h b/chromecast/media/cma/pipeline/av_pipeline_impl.h

index 19b8498ce789d0d9ffdb740de4d46c1056418e0b..7c917ae521030e40c7771142a336b2d7e3815555 100644

--- a/chromecast/media/cma/pipeline/av_pipeline_impl.h

+++ b/chromecast/media/cma/pipeline/av_pipeline_impl.h

@@ -59,6 +59,10 @@ class AvPipelineImpl : public base::RefCountedThreadSafe<AvPipelineImpl> {

// Initialize the pipeline.

bool Initialize();

+ // Destroy the pipeline. No other calls into AvPipelineImpl must be made

+ // after this.

+ void Finalize();

// Setup the pipeline and ensure samples are available for the given media

// time, then start rendering samples.

bool StartPlayingFrom(base::TimeDelta time,