chromecast/media/cma/filters/cma_renderer.cc - Issue 987513006: Chromecast: fixes crash in AvPipelineImpl teardown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/media/cma/filters/cma_renderer.cc

Issue 987513006: Chromecast: fixes crash in AvPipelineImpl teardown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: changes Finalize signature (not a build failure on arm...) Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromecast/media/cma/filters/cma_renderer.cc

diff --git a/chromecast/media/cma/filters/cma_renderer.cc b/chromecast/media/cma/filters/cma_renderer.cc

index a8a46f5d2646e7da562215fd6ae9f8c0be145a70..1473f02af0fc36c9b484b7b54b20d12a06161bb2 100644

--- a/chromecast/media/cma/filters/cma_renderer.cc

+++ b/chromecast/media/cma/filters/cma_renderer.cc

@@ -66,6 +66,9 @@ CmaRenderer::~CmaRenderer() {

base::ResetAndReturn(&init_cb_).Run(::media::PIPELINE_ERROR_ABORT);

else if (!flush_cb_.is_null())

base::ResetAndReturn(&flush_cb_).Run();

+ if (has_audio_ || has_video_)

+ media_pipeline_->Stop();

}

void CmaRenderer::Initialize(

« no previous file with comments | « no previous file | chromecast/media/cma/pipeline/audio_pipeline_impl.cc » ('j') | no next file with comments »