content/browser/mock_content_browser_client.cc - Issue 9837074: Make it so that allow_js_access: false can be used with background pages created by window.open.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/mock_content_browser_client.cc

Issue 9837074: Make it so that allow_js_access: false can be used with background pages created by window.open. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Revised approach based on http://crrev.com/125180. Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser.cc ('K') | « content/browser/mock_content_browser_client.h ('k') | content/browser/renderer_host/render_message_filter.cc » ('j') | content/public/browser/content_browser_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/mock_content_browser_client.cc

diff --git a/content/browser/mock_content_browser_client.cc b/content/browser/mock_content_browser_client.cc

index 0eb60d7267146b7ea19996baddc056754b79021c..e2ae25e15f5cf2df756c60b59bd9a63f6ce98164 100644

--- a/content/browser/mock_content_browser_client.cc

+++ b/content/browser/mock_content_browser_client.cc

@@ -239,13 +239,14 @@ void MockContentBrowserClient::CancelDesktopNotification(

int notification_id) {

}

-bool MockContentBrowserClient::CanCreateWindow(

+content::ContentBrowserClient::CanCreateWindowResult

+MockContentBrowserClient::CanCreateWindow(

const GURL& opener_url,

const GURL& source_origin,

WindowContainerType container_type,

ResourceContext* context,

int render_process_id) {

- return true;

+ return CAN_CREATE_WINDOW;

}

std::string MockContentBrowserClient::GetWorkerProcessTitle(