Make it so that allow_js_access: false can be used with background pages created by window.open.

content/public/browser/content_browser_client.h

Index: content/public/browser/content_browser_client.h
diff --git a/content/public/browser/content_browser_client.h b/content/public/browser/content_browser_client.h
index c9303d93a919ac054531146147151a5625e623ee..78d095cf7a78bba024ce16f52b25bbcc51468c95 100644
--- a/content/public/browser/content_browser_client.h
+++ b/content/public/browser/content_browser_client.h
@@ -91,6 +91,16 @@ class ContentBrowserClient {
  public:
   virtual ~ContentBrowserClient() {}
 
+  enum CanCreateWindowResult {

[jam, 2012/03/28 02:38:26]

nit: see hte other enums in content API to see the convention, i.e. this would
be CAN_CREATE_WINDOW_RESULTS_DISALLOW, ...ALLOW, ...ALLOW_NO_JS_ACCESS.

but can we avoid the enum altogether? because if you add it and are passing it
around in content, by convention to the API this needs to be in a separate file
which seems nice to avoid (we try to keep the files in the public directories to
a minimum). so another boolean out parameter on the function that is
"no_javascript_access" (we also don't abbreviate per the style guide)

[Mihai Parparita -not on Chrome, 2012/03/28 20:29:01]

Went with the boolean out parameter approach.

+    // The given window canot be created.

[Charlie Reis, 2012/03/27 23:19:27]

nit: cannot

[Mihai Parparita -not on Chrome, 2012/03/28 20:29:01]

Obsolete, this enum is gone per John's comments.

+    CANNOT_CREATE_WINDOW,
+    // The given window can be created.
+    CAN_CREATE_WINDOW,
+    // The given window can be created, but it is not allowed to be scriptable,
+    // and should be put in a separate process.
+    CAN_CREATE_WINDOW_NO_JS_ACCESS
+  };
+
   // Allows the embedder to set any number of custom BrowserMainParts
   // implementations for the browser startup code. See comments in
   // browser_main_parts.h.
@@ -330,10 +340,10 @@ class ContentBrowserClient {
       int render_view_id,
       int notification_id) = 0;
 
-  // Returns true if the given page is allowed to open a window of the given
+  // Returns whether the given page is allowed to open a window of the given
   // type.
   // This is called on the IO thread.
-  virtual bool CanCreateWindow(
+  virtual CanCreateWindowResult CanCreateWindow(
       const GURL& opener_url,
       const GURL& source_origin,
       WindowContainerType container_type,