Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1290)

Unified Diff: content/browser/renderer_host/render_message_filter.cc

Issue 9837074: Make it so that allow_js_access: false can be used with background pages created by window.open. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Revised approach based on http://crrev.com/125180. Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_message_filter.cc
diff --git a/content/browser/renderer_host/render_message_filter.cc b/content/browser/renderer_host/render_message_filter.cc
index 0684b0ffe77e6c5e71c9089403cfcb020a1b142e..e6d02dbfb6ec042c0d25499853bb6b2046b2861a 100644
--- a/content/browser/renderer_host/render_message_filter.cc
+++ b/content/browser/renderer_host/render_message_filter.cc
@@ -402,10 +402,13 @@ void RenderMessageFilter::OnMsgCreateWindow(
int* route_id,
int* surface_id,
int64* cloned_session_storage_namespace_id) {
- if (!content::GetContentClient()->browser()->CanCreateWindow(
+ content::ContentBrowserClient::CanCreateWindowResult result =
+ content::GetContentClient()->browser()->CanCreateWindow(
GURL(params.opener_url), GURL(params.opener_security_origin),
params.window_container_type, resource_context_,
- render_process_id_)) {
+ render_process_id_);
+
+ if (result == content::ContentBrowserClient::CANNOT_CREATE_WINDOW) {
*route_id = MSG_ROUTING_NONE;
*surface_id = 0;
return;
@@ -427,6 +430,7 @@ void RenderMessageFilter::OnMsgCreateWindow(
#endif
render_widget_helper_->CreateNewWindow(params,
+ result,
peer_handle(),
route_id,
surface_id);

Powered by Google App Engine
This is Rietveld 408576698