content/browser/mock_content_browser_client.h - Issue 9837074: Make it so that allow_js_access: false can be used with background pages created by window.open.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/mock_content_browser_client.h

Issue 9837074: Make it so that allow_js_access: false can be used with background pages created by window.open. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Revised approach based on http://crrev.com/125180. Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser.cc ('K') | « chrome/test/data/extensions/manifest_tests/background_allow_no_js_access2.json ('k') | content/browser/mock_content_browser_client.cc » ('j') | content/public/browser/content_browser_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/mock_content_browser_client.h

diff --git a/content/browser/mock_content_browser_client.h b/content/browser/mock_content_browser_client.h

index e143f3ddd28bab158115f5b851f7dde2f6dd874f..1b7a129d6606384ed310e7fa3998ed059f95ee89 100644

--- a/content/browser/mock_content_browser_client.h

+++ b/content/browser/mock_content_browser_client.h

@@ -132,7 +132,7 @@ class MockContentBrowserClient : public ContentBrowserClient {

int render_process_id,

int render_view_id,

int notification_id) OVERRIDE;

- virtual bool CanCreateWindow(

+ virtual CanCreateWindowResult CanCreateWindow(

const GURL& opener_url,

const GURL& source_origin,

WindowContainerType container_type,