Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9814030: get rid of old options pages (Closed)

Created:
8 years, 9 months ago by Evan Stade
Modified:
8 years, 9 months ago
Reviewers:
csilv, Dan Beam
CC:
chromium-reviews, GeorgeY, ncarter (slow), yusukes+watch_chromium.org, Raghu Simha, dhollowa+watch_chromium.org, nkostylev+watch_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, arv (Not doing code reviews), dyu1, tfarina, Ilya Sherman, tim (not reviewing), akalin
Visibility:
Public.

Description

get rid of old options pages BUG=none TEST=manual, compile, migrated tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128406

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : chromeos fixes #

Total comments: 2

Patch Set 4 : fix or disable a lot of tests #

Patch Set 5 : sync'd #

Patch Set 6 : chromeos compile fix #

Patch Set 7 : more fixes #

Total comments: 9
Unified diffs Side-by-side diffs Delta from patch set Stats (+323 lines, -39875 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 4 5 6 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/app_controller_mac.mm View 1 2 3 4 5 6 1 chunk +5 lines, -22 lines 0 comments Download
M chrome/browser/browser_about_handler.cc View 1 2 3 4 5 6 2 chunks +6 lines, -18 lines 0 comments Download
M chrome/browser/chromeos/cros_settings.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_browsertest.cc View 1 2 3 4 5 6 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/extension_ui_unittest.cc View 1 2 3 4 5 6 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/cloud_print/cloud_print_setup_done.html View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/resources/options/OWNERS View 1 2 3 4 5 6 1 chunk +0 lines, -4 lines 0 comments Download
D chrome/browser/resources/options/about_page.css View 1 2 3 4 5 6 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/browser/resources/options/about_page.html View 1 2 3 4 5 6 1 chunk +0 lines, -119 lines 0 comments Download
D chrome/browser/resources/options/about_page.js View 1 2 3 4 5 6 1 chunk +0 lines, -227 lines 0 comments Download
D chrome/browser/resources/options/advanced_options.css View 1 2 3 4 5 6 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/browser/resources/options/advanced_options.html View 1 2 3 4 5 6 1 chunk +0 lines, -242 lines 0 comments Download
D chrome/browser/resources/options/advanced_options.js View 1 2 3 4 5 6 1 chunk +0 lines, -276 lines 0 comments Download
D chrome/browser/resources/options/alert_overlay.css View 1 2 3 4 5 6 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/browser/resources/options/alert_overlay.html View 1 2 3 4 5 6 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/resources/options/alert_overlay.js View 1 2 3 4 5 6 1 chunk +0 lines, -144 lines 0 comments Download
D chrome/browser/resources/options/amex.png View 1 2 3 4 5 6 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/options/autofill_edit_address_overlay.html View 1 2 3 4 5 6 1 chunk +0 lines, -99 lines 0 comments Download
D chrome/browser/resources/options/autofill_edit_address_overlay.js View 1 2 3 4 5 6 1 chunk +0 lines, -325 lines 0 comments Download
D chrome/browser/resources/options/autofill_edit_creditcard_overlay.html View 1 2 3 4 5 6 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/browser/resources/options/autofill_edit_creditcard_overlay.js View 1 2 3 4 5 6 1 chunk +0 lines, -205 lines 0 comments Download
D chrome/browser/resources/options/autofill_options.css View 1 2 3 4 5 6 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/browser/resources/options/autofill_options.html View 1 2 3 4 5 6 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/browser/resources/options/autofill_options.js View 1 2 3 4 5 6 1 chunk +0 lines, -230 lines 0 comments Download
D chrome/browser/resources/options/autofill_options_list.js View 1 2 3 4 5 6 1 chunk +0 lines, -506 lines 0 comments Download
D chrome/browser/resources/options/autofill_overlay.css View 1 2 3 4 5 6 1 chunk +0 lines, -95 lines 0 comments Download
D chrome/browser/resources/options/browser_options.html View 1 2 3 4 5 6 1 chunk +0 lines, -135 lines 0 comments Download
D chrome/browser/resources/options/browser_options.js View 1 2 3 4 5 6 1 chunk +0 lines, -388 lines 0 comments Download
D chrome/browser/resources/options/browser_options_page.css View 1 2 3 4 5 6 1 chunk +0 lines, -99 lines 0 comments Download
D chrome/browser/resources/options/browser_options_startup_page_list.js View 1 2 3 4 5 6 1 chunk +0 lines, -310 lines 0 comments Download
D chrome/browser/resources/options/cc-generic.png View 1 2 3 4 5 6 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/options/certificate_backup_overlay.html View 1 2 3 4 5 6 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/resources/options/certificate_backup_overlay.js View 1 2 3 4 5 6 1 chunk +0 lines, -116 lines 0 comments Download
D chrome/browser/resources/options/certificate_edit_ca_trust_overlay.html View 1 2 3 4 5 6 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/browser/resources/options/certificate_edit_ca_trust_overlay.js View 1 2 3 4 5 6 1 chunk +0 lines, -164 lines 0 comments Download
D chrome/browser/resources/options/certificate_import_error_overlay.html View 1 2 3 4 5 6 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/browser/resources/options/certificate_import_error_overlay.js View 1 2 3 4 5 6 1 chunk +0 lines, -68 lines 0 comments Download
D chrome/browser/resources/options/certificate_manager.css View 1 2 3 4 5 6 1 chunk +0 lines, -15 lines 0 comments Download
D chrome/browser/resources/options/certificate_manager.html View 1 2 3 4 5 6 1 chunk +0 lines, -129 lines 0 comments Download
D chrome/browser/resources/options/certificate_manager.js View 1 2 3 4 5 6 1 chunk +0 lines, -253 lines 0 comments Download
D chrome/browser/resources/options/certificate_restore_overlay.html View 1 2 3 4 5 6 1 chunk +0 lines, -17 lines 0 comments Download
D chrome/browser/resources/options/certificate_restore_overlay.js View 1 2 3 4 5 6 1 chunk +0 lines, -97 lines 0 comments Download
D chrome/browser/resources/options/certificate_tree.css View 1 2 3 4 5 6 1 chunk +0 lines, -8 lines 0 comments Download
D chrome/browser/resources/options/certificate_tree.js View 1 2 3 4 5 6 1 chunk +0 lines, -128 lines 0 comments Download
D chrome/browser/resources/options/chromeos/accounts_options.html View 1 2 3 4 5 6 1 chunk +0 lines, -63 lines 0 comments Download
D chrome/browser/resources/options/chromeos/accounts_options.js View 1 2 3 4 5 6 1 chunk +0 lines, -165 lines 0 comments Download
D chrome/browser/resources/options/chromeos/accounts_options_page.css View 1 2 3 4 5 6 1 chunk +0 lines, -87 lines 0 comments Download
D chrome/browser/resources/options/chromeos/accounts_user_list.js View 1 2 3 4 5 6 1 chunk +0 lines, -194 lines 0 comments Download
D chrome/browser/resources/options/chromeos/accounts_user_name_edit.js View 1 2 3 4 5 6 1 chunk +0 lines, -121 lines 0 comments Download
D chrome/browser/resources/options/chromeos/bluetooth.css View 1 2 3 4 5 6 1 chunk +0 lines, -136 lines 0 comments Download
D chrome/browser/resources/options/chromeos/bluetooth_add_device_overlay.html View 1 2 3 4 5 6 1 chunk +0 lines, -22 lines 0 comments Download
D chrome/browser/resources/options/chromeos/bluetooth_add_device_overlay.js View 1 2 3 4 5 6 1 chunk +0 lines, -77 lines 0 comments Download
D chrome/browser/resources/options/chromeos/bluetooth_device_list.js View 1 2 3 4 5 6 1 chunk +0 lines, -237 lines 0 comments Download
D chrome/browser/resources/options/chromeos/bluetooth_pair_device_overlay.html View 1 2 3 4 5 6 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser/resources/options/chromeos/bluetooth_pair_device_overlay.js View 1 2 3 4 5 6 1 chunk +0 lines, -227 lines 0 comments Download
D chrome/browser/resources/options/chromeos/cellular_plan_element.js View 1 2 3 4 5 6 1 chunk +0 lines, -132 lines 0 comments Download
D chrome/browser/resources/options/chromeos/change_picture_options.css View 1 2 3 4 5 6 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/browser/resources/options/chromeos/change_picture_options.html View 1 2 3 4 5 6 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/browser/resources/options/chromeos/change_picture_options.js View 1 2 3 4 5 6 1 chunk +0 lines, -268 lines 0 comments Download
D chrome/browser/resources/options/chromeos/headset.png View 1 2 3 4 5 6 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/options/chromeos/internet_detail.html View 1 2 3 4 5 6 1 chunk +0 lines, -378 lines 0 comments Download
D chrome/browser/resources/options/chromeos/internet_detail.js View 1 2 3 4 5 6 1 chunk +0 lines, -268 lines 0 comments Download
D chrome/browser/resources/options/chromeos/internet_detail_ip_config_list.js View 1 2 3 4 5 6 1 chunk +0 lines, -99 lines 0 comments Download
D chrome/browser/resources/options/chromeos/internet_network_element.js View 1 2 3 4 5 6 1 chunk +0 lines, -316 lines 0 comments Download
D chrome/browser/resources/options/chromeos/internet_options.html View 1 2 3 4 5 6 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/browser/resources/options/chromeos/internet_options.js View 1 2 3 4 5 6 1 chunk +0 lines, -698 lines 0 comments Download
D chrome/browser/resources/options/chromeos/internet_options_page.css View 1 2 3 4 5 6 1 chunk +0 lines, -171 lines 0 comments Download
D chrome/browser/resources/options/chromeos/keyboard.png View 1 2 3 4 5 6 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/options/chromeos/language_chewing_options.html View 1 2 3 4 5 6 1 chunk +0 lines, -141 lines 0 comments Download
D chrome/browser/resources/options/chromeos/language_customize_modifier_keys_overlay.html View 1 2 3 4 5 6 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/browser/resources/options/chromeos/language_hangul_options.html View 1 2 3 4 5 6 1 chunk +0 lines, -18 lines 0 comments Download
D chrome/browser/resources/options/chromeos/language_mozc_options.html View 1 2 3 4 5 6 1 chunk +0 lines, -135 lines 0 comments Download
D chrome/browser/resources/options/chromeos/language_pinyin_options.html View 1 2 3 4 5 6 1 chunk +0 lines, -148 lines 0 comments Download
D chrome/browser/resources/options/chromeos/mouse.png View 1 2 3 4 5 6 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/options/chromeos/proxy.css View 1 2 3 4 5 6 1 chunk +0 lines, -11 lines 0 comments Download
D chrome/browser/resources/options/chromeos/proxy.html View 1 2 3 4 5 6 1 chunk +0 lines, -141 lines 0 comments Download
D chrome/browser/resources/options/chromeos/proxy_options.js View 1 2 3 4 5 6 1 chunk +0 lines, -244 lines 0 comments Download
D chrome/browser/resources/options/chromeos/proxy_rules_list.js View 1 2 3 4 5 6 1 chunk +0 lines, -139 lines 0 comments Download
D chrome/browser/resources/options/chromeos/system_options.html View 1 2 3 4 5 6 1 chunk +0 lines, -128 lines 0 comments Download
D chrome/browser/resources/options/chromeos/system_options.js View 1 2 3 4 5 6 1 chunk +0 lines, -248 lines 0 comments Download
D chrome/browser/resources/options/chromeos/system_options_page.css View 1 2 3 4 5 6 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/browser/resources/options/chromeos/virtual_keyboard.css View 1 2 3 4 5 6 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser/resources/options/chromeos/virtual_keyboard.html View 1 2 3 4 5 6 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/browser/resources/options/chromeos/virtual_keyboard.js View 1 2 3 4 5 6 1 chunk +0 lines, -92 lines 0 comments Download
D chrome/browser/resources/options/chromeos/virtual_keyboard_list.js View 1 2 3 4 5 6 1 chunk +0 lines, -146 lines 0 comments Download
D chrome/browser/resources/options/chromeos/warning.png View 1 2 3 4 5 6 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/options/clear_browser_data_overlay.css View 1 2 3 4 5 6 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser/resources/options/clear_browser_data_overlay.html View 1 2 3 4 5 6 1 chunk +0 lines, -73 lines 0 comments Download
D chrome/browser/resources/options/clear_browser_data_overlay.js View 1 2 3 4 5 6 1 chunk +0 lines, -110 lines 0 comments Download
D chrome/browser/resources/options/content_settings.css View 1 2 3 4 5 6 1 chunk +0 lines, -74 lines 0 comments Download
D chrome/browser/resources/options/content_settings.html View 1 2 3 4 5 6 1 chunk +0 lines, -260 lines 0 comments Download
D chrome/browser/resources/options/content_settings.js View 1 2 3 4 5 6 1 chunk +0 lines, -147 lines 0 comments Download
D chrome/browser/resources/options/content_settings_exceptions_area.html View 1 2 3 4 5 6 1 chunk +0 lines, -75 lines 0 comments Download
D chrome/browser/resources/options/content_settings_exceptions_area.js View 1 2 3 4 5 6 1 chunk +0 lines, -551 lines 0 comments Download
D chrome/browser/resources/options/content_settings_ui.js View 1 2 3 4 5 6 1 chunk +0 lines, -67 lines 0 comments Download
D chrome/browser/resources/options/controlled_setting.js View 1 2 3 4 5 6 1 chunk +0 lines, -143 lines 0 comments Download
D chrome/browser/resources/options/cookies_list.js View 1 2 3 4 5 6 1 chunk +0 lines, -855 lines 0 comments Download
D chrome/browser/resources/options/cookies_view.css View 1 2 3 4 5 6 1 chunk +0 lines, -182 lines 0 comments Download
D chrome/browser/resources/options/cookies_view.html View 1 2 3 4 5 6 1 chunk +0 lines, -15 lines 0 comments Download
D chrome/browser/resources/options/cookies_view.js View 1 2 3 4 5 6 1 chunk +0 lines, -140 lines 0 comments Download
D chrome/browser/resources/options/deletable_item_list.js View 1 2 3 4 5 6 1 chunk +0 lines, -185 lines 0 comments Download
D chrome/browser/resources/options/diners.png View 1 2 3 4 5 6 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/options/discover.png View 1 2 3 4 5 6 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/options/extension_list.js View 1 2 3 4 5 6 1 chunk +0 lines, -773 lines 0 comments Download
D chrome/browser/resources/options/extension_settings.css View 1 2 3 4 5 6 1 chunk +0 lines, -291 lines 0 comments Download
D chrome/browser/resources/options/extension_settings.html View 1 2 3 4 5 6 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/browser/resources/options/extension_settings.js View 1 2 3 4 5 6 1 chunk +0 lines, -203 lines 0 comments Download
D chrome/browser/resources/options/font_settings.css View 1 2 3 4 5 6 1 chunk +0 lines, -41 lines 0 comments Download
D chrome/browser/resources/options/font_settings.html View 1 2 3 4 5 6 1 chunk +0 lines, -82 lines 0 comments Download
D chrome/browser/resources/options/font_settings.js View 1 2 3 4 5 6 1 chunk +0 lines, -229 lines 0 comments Download
D chrome/browser/resources/options/handler_options.css View 1 2 3 4 5 6 1 chunk +0 lines, -57 lines 0 comments Download
D chrome/browser/resources/options/handler_options.html View 1 2 3 4 5 6 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/browser/resources/options/handler_options.js View 1 2 3 4 5 6 1 chunk +0 lines, -77 lines 0 comments Download
D chrome/browser/resources/options/handler_options_list.js View 1 2 3 4 5 6 1 chunk +0 lines, -229 lines 0 comments Download
D chrome/browser/resources/options/import_data_overlay.css View 1 2 3 4 5 6 1 chunk +0 lines, -23 lines 0 comments Download
D chrome/browser/resources/options/import_data_overlay.html View 1 2 3 4 5 6 1 chunk +0 lines, -70 lines 0 comments Download
D chrome/browser/resources/options/import_data_overlay.js View 1 2 3 4 5 6 1 chunk +0 lines, -222 lines 0 comments Download
D chrome/browser/resources/options/inline_editable_list.js View 1 2 3 4 5 6 1 chunk +0 lines, -414 lines 0 comments Download
D chrome/browser/resources/options/instant_confirm_overlay.html View 1 2 3 4 5 6 1 chunk +0 lines, -16 lines 0 comments Download
D chrome/browser/resources/options/instant_confirm_overlay.js View 1 2 3 4 5 6 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/browser/resources/options/jcb.png View 1 2 3 4 5 6 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/options/language_add_language_overlay.html View 1 2 3 4 5 6 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser/resources/options/language_add_language_overlay.js View 1 2 3 4 5 6 1 chunk +0 lines, -73 lines 0 comments Download
D chrome/browser/resources/options/language_list.js View 1 2 3 4 5 6 1 chunk +0 lines, -485 lines 0 comments Download
D chrome/browser/resources/options/language_options.css View 1 2 3 4 5 6 1 chunk +0 lines, -239 lines 0 comments Download
D chrome/browser/resources/options/language_options.html View 1 2 3 4 5 6 1 chunk +0 lines, -78 lines 0 comments Download
D chrome/browser/resources/options/language_options.js View 1 2 3 4 5 6 1 chunk +0 lines, -816 lines 0 comments Download
D chrome/browser/resources/options/manage_profile_overlay.css View 1 2 3 4 5 6 1 chunk +0 lines, -88 lines 0 comments Download
D chrome/browser/resources/options/manage_profile_overlay.html View 1 2 3 4 5 6 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/resources/options/manage_profile_overlay.js View 1 2 3 4 5 6 1 chunk +0 lines, -266 lines 0 comments Download
D chrome/browser/resources/options/mastercard.png View 1 2 3 4 5 6 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/options/options.html View 1 2 3 4 5 6 1 chunk +0 lines, -184 lines 0 comments Download
D chrome/browser/resources/options/options.js View 1 2 3 4 5 6 1 chunk +0 lines, -245 lines 0 comments Download
D chrome/browser/resources/options/options_bundle.js View 1 2 3 4 5 6 1 chunk +0 lines, -93 lines 0 comments Download
D chrome/browser/resources/options/options_page.css View 1 2 3 4 5 6 1 chunk +0 lines, -742 lines 0 comments Download
D chrome/browser/resources/options/pack_extension_overlay.css View 1 2 3 4 5 6 1 chunk +0 lines, -18 lines 0 comments Download
D chrome/browser/resources/options/pack_extension_overlay.html View 1 2 3 4 5 6 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/browser/resources/options/pack_extension_overlay.js View 1 2 3 4 5 6 1 chunk +0 lines, -118 lines 0 comments Download
D chrome/browser/resources/options/password_manager.css View 1 2 3 4 5 6 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/browser/resources/options/password_manager.html View 1 2 3 4 5 6 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/browser/resources/options/password_manager.js View 1 2 3 4 5 6 1 chunk +0 lines, -228 lines 0 comments Download
D chrome/browser/resources/options/password_manager_list.css View 1 2 3 4 5 6 1 chunk +0 lines, -69 lines 0 comments Download
D chrome/browser/resources/options/password_manager_list.js View 1 2 3 4 5 6 1 chunk +0 lines, -283 lines 0 comments Download
D chrome/browser/resources/options/personal_options.css View 1 2 3 4 5 6 1 chunk +0 lines, -66 lines 0 comments Download
D chrome/browser/resources/options/personal_options.html View 1 2 3 4 5 6 1 chunk +0 lines, -165 lines 0 comments Download
D chrome/browser/resources/options/personal_options.js View 1 2 3 4 5 6 1 chunk +0 lines, -375 lines 0 comments Download
D chrome/browser/resources/options/personal_options_profile_list.js View 1 2 3 4 5 6 1 chunk +0 lines, -105 lines 0 comments Download
D chrome/browser/resources/options/profiles_icon_grid.js View 1 2 3 4 5 6 1 chunk +0 lines, -68 lines 0 comments Download
D chrome/browser/resources/options/search_engine_manager.css View 1 2 3 4 5 6 1 chunk +0 lines, -64 lines 0 comments Download
D chrome/browser/resources/options/search_engine_manager.html View 1 2 3 4 5 6 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/browser/resources/options/search_engine_manager.js View 1 2 3 4 5 6 1 chunk +0 lines, -125 lines 0 comments Download
D chrome/browser/resources/options/search_engine_manager_engine_list.js View 1 2 3 4 5 6 1 chunk +0 lines, -316 lines 0 comments Download
D chrome/browser/resources/options/search_page.css View 1 2 3 4 5 6 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/browser/resources/options/search_page.html View 1 2 3 4 5 6 1 chunk +0 lines, -10 lines 0 comments Download
D chrome/browser/resources/options/search_page.js View 1 2 3 4 5 6 1 chunk +0 lines, -598 lines 0 comments Download
D chrome/browser/resources/options/show_password.png View 1 2 3 4 5 6 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/options/solo.png View 1 2 3 4 5 6 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/options/subpages_tab_controls.css View 1 2 3 4 5 6 1 chunk +0 lines, -66 lines 0 comments Download
D chrome/browser/resources/options/success-large.png View 1 2 3 4 5 6 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/options/visa.png View 1 2 3 4 5 6 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/options/zippy.png View 1 2 3 4 5 6 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/options2/amex.png View 1 2 3 4 5 6 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/options2/cc-generic.png View 1 2 3 4 5 6 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/options2/diners.png View 1 2 3 4 5 6 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/options2/discover.png View 1 2 3 4 5 6 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/options2/jcb.png View 1 2 3 4 5 6 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/options2/mastercard.png View 1 2 3 4 5 6 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/options2/show_password.png View 1 2 3 4 5 6 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/options2/solo.png View 1 2 3 4 5 6 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/options2/visa.png View 1 2 3 4 5 6 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/options_resources.grd View 1 2 3 4 5 6 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/browser/sync/sync_setup_wizard_unittest.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 3 4 5 6 7 chunks +34 lines, -62 lines 0 comments Download
M chrome/browser/ui/browser_navigator_browsertest.cc View 1 2 3 4 5 6 25 chunks +38 lines, -48 lines 0 comments Download
M chrome/browser/ui/webui/bidi_checker_web_ui_test.cc View 1 2 3 4 5 6 4 chunks +16 lines, -8 lines 1 comment Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 2 3 4 5 6 2 chunks +4 lines, -7 lines 1 comment Download
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 1 comment Download
M chrome/browser/ui/webui/chromeos/proxy_settings_ui.h View 1 2 3 4 5 6 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/proxy_settings_ui.cc View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/webui/extensions/extension_settings_handler.h View 1 2 3 4 5 6 4 chunks +11 lines, -8 lines 0 comments Download
A + chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 2 3 4 5 6 4 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extensions_ui.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/webui/extensions/pack_extension_handler.h View 1 2 3 4 5 6 3 chunks +6 lines, -7 lines 0 comments Download
A + chrome/browser/ui/webui/extensions/pack_extension_handler.cc View 1 2 3 4 5 6 2 chunks +1 line, -3 lines 0 comments Download
D chrome/browser/ui/webui/options/advanced_options_browsertest.js View 1 2 3 4 5 6 1 chunk +0 lines, -63 lines 0 comments Download
D chrome/browser/ui/webui/options/advanced_options_handler.h View 1 2 3 4 5 6 1 chunk +0 lines, -183 lines 0 comments Download
D chrome/browser/ui/webui/options/advanced_options_handler.cc View 1 2 3 4 5 6 1 chunk +0 lines, -677 lines 0 comments Download
D chrome/browser/ui/webui/options/advanced_options_utils.h View 1 2 3 4 5 6 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/browser/ui/webui/options/advanced_options_utils_mac.mm View 1 2 3 4 5 6 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/browser/ui/webui/options/advanced_options_utils_win.cc View 1 2 3 4 5 6 1 chunk +0 lines, -69 lines 0 comments Download
D chrome/browser/ui/webui/options/advanced_options_utils_x11.cc View 1 2 3 4 5 6 1 chunk +0 lines, -154 lines 0 comments Download
D chrome/browser/ui/webui/options/autofill_options_browsertest.js View 1 2 3 4 5 6 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser/ui/webui/options/autofill_options_handler.h View 1 2 3 4 5 6 1 chunk +0 lines, -89 lines 0 comments Download
D chrome/browser/ui/webui/options/autofill_options_handler.cc View 1 2 3 4 5 6 1 chunk +0 lines, -618 lines 0 comments Download
D chrome/browser/ui/webui/options/browser_options_browsertest.js View 1 2 3 4 5 6 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser/ui/webui/options/browser_options_handler.h View 1 2 3 4 5 6 1 chunk +0 lines, -159 lines 0 comments Download
D chrome/browser/ui/webui/options/browser_options_handler.cc View 1 2 3 4 5 6 1 chunk +0 lines, -586 lines 0 comments Download
D chrome/browser/ui/webui/options/certificate_manager_browsertest.js View 1 2 3 4 5 6 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/browser/ui/webui/options/certificate_manager_handler.h View 1 2 3 4 5 6 1 chunk +0 lines, -181 lines 0 comments Download
D chrome/browser/ui/webui/options/certificate_manager_handler.cc View 1 2 3 4 5 6 1 chunk +0 lines, -1054 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/about_page_handler.h View 1 2 3 4 5 6 1 chunk +0 lines, -74 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/about_page_handler.cc View 1 2 3 4 5 6 1 chunk +0 lines, -455 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/accounts_options_handler.h View 1 2 3 4 5 6 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/accounts_options_handler.cc View 1 2 3 4 5 6 1 chunk +0 lines, -132 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/bluetooth_options_handler.h View 1 2 3 4 5 6 1 chunk +0 lines, -125 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/bluetooth_options_handler.cc View 1 2 3 4 5 6 1 chunk +0 lines, -288 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.h View 1 2 3 4 5 6 1 chunk +0 lines, -113 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc View 1 2 3 4 5 6 1 chunk +0 lines, -347 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.h View 1 2 3 4 5 6 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc View 1 2 3 4 5 6 1 chunk +0 lines, -282 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.h View 1 2 3 4 5 6 1 chunk +0 lines, -73 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc View 1 2 3 4 5 6 1 chunk +0 lines, -238 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/guest_mode_options_ui_uitest.cc View 1 2 3 4 5 6 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/internet_options_handler.h View 1 2 3 4 5 6 1 chunk +0 lines, -150 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc View 1 2 3 4 5 6 1 chunk +0 lines, -1418 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/language_chewing_handler.h View 1 2 3 4 5 6 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/language_chewing_handler.cc View 1 2 3 4 5 6 1 chunk +0 lines, -103 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/language_customize_modifier_keys_handler.h View 1 2 3 4 5 6 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/language_customize_modifier_keys_handler.cc View 1 2 3 4 5 6 1 chunk +0 lines, -79 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/language_hangul_handler.h View 1 2 3 4 5 6 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/language_hangul_handler.cc View 1 2 3 4 5 6 1 chunk +0 lines, -47 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/language_mozc_handler.h View 1 2 3 4 5 6 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/language_mozc_handler.cc View 1 2 3 4 5 6 1 chunk +0 lines, -70 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/language_options_util.h View 1 2 3 4 5 6 1 chunk +0 lines, -83 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/language_options_util.cc View 1 2 3 4 5 6 1 chunk +0 lines, -18 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/language_pinyin_handler.h View 1 2 3 4 5 6 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/language_pinyin_handler.cc View 1 2 3 4 5 6 1 chunk +0 lines, -67 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/proxy_handler.h View 1 2 3 4 5 6 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/proxy_handler.cc View 1 2 3 4 5 6 1 chunk +0 lines, -87 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/stats_options_handler.h View 1 2 3 4 5 6 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/stats_options_handler.cc View 1 2 3 4 5 6 1 chunk +0 lines, -45 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/system_options_handler.h View 1 2 3 4 5 6 1 chunk +0 lines, -63 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/system_options_handler.cc View 1 2 3 4 5 6 1 chunk +0 lines, -268 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/system_settings_provider.h View 1 2 3 4 5 6 1 chunk +0 lines, -74 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/system_settings_provider.cc View 1 2 3 4 5 6 1 chunk +0 lines, -331 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/user_image_source.h View 1 2 3 4 5 6 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/user_image_source.cc View 1 2 3 4 5 6 1 chunk +0 lines, -54 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/virtual_keyboard_manager_handler.h View 1 2 3 4 5 6 1 chunk +0 lines, -77 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/virtual_keyboard_manager_handler.cc View 1 2 3 4 5 6 1 chunk +0 lines, -232 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/virtual_keyboard_manager_handler_unittest.cc View 1 2 3 4 5 6 1 chunk +0 lines, -550 lines 0 comments Download
D chrome/browser/ui/webui/options/clear_browser_data_handler.h View 1 2 3 4 5 6 1 chunk +0 lines, -45 lines 0 comments Download
D chrome/browser/ui/webui/options/clear_browser_data_handler.cc View 1 2 3 4 5 6 1 chunk +0 lines, -142 lines 0 comments Download
D chrome/browser/ui/webui/options/content_options_browsertest.js View 1 2 3 4 5 6 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser/ui/webui/options/content_settings_exception_area_browsertest.js View 1 2 3 4 5 6 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/browser/ui/webui/options/content_settings_handler.h View 1 2 3 4 5 6 1 chunk +0 lines, -118 lines 0 comments Download
D chrome/browser/ui/webui/options/content_settings_handler.cc View 1 2 3 4 5 6 1 chunk +0 lines, -901 lines 0 comments Download
D chrome/browser/ui/webui/options/cookies_view_browsertest.js View 1 2 3 4 5 6 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser/ui/webui/options/cookies_view_handler.h View 1 2 3 4 5 6 1 chunk +0 lines, -69 lines 0 comments Download
D chrome/browser/ui/webui/options/cookies_view_handler.cc View 1 2 3 4 5 6 1 chunk +0 lines, -223 lines 0 comments Download
D chrome/browser/ui/webui/options/core_options_handler.cc View 1 2 3 4 5 6 1 chunk +0 lines, -457 lines 0 comments Download
D chrome/browser/ui/webui/options/extension_settings_handler.h View 1 2 3 4 5 6 1 chunk +0 lines, -197 lines 0 comments Download
D chrome/browser/ui/webui/options/extension_settings_handler.cc View 1 2 3 4 5 6 1 chunk +0 lines, -791 lines 0 comments Download
D chrome/browser/ui/webui/options/font_settings_browsertest.js View 1 2 3 4 5 6 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser/ui/webui/options/font_settings_handler.h View 1 2 3 4 5 6 1 chunk +0 lines, -58 lines 0 comments Download
D chrome/browser/ui/webui/options/font_settings_handler.cc View 1 2 3 4 5 6 1 chunk +0 lines, -208 lines 0 comments Download
D chrome/browser/ui/webui/options/font_settings_utils.h View 1 2 3 4 5 6 1 chunk +0 lines, -22 lines 0 comments Download
D chrome/browser/ui/webui/options/font_settings_utils_mac.mm View 1 2 3 4 5 6 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/ui/webui/options/font_settings_utils_win.cc View 1 2 3 4 5 6 1 chunk +0 lines, -11 lines 0 comments Download
D chrome/browser/ui/webui/options/font_settings_utils_x11.cc View 1 2 3 4 5 6 1 chunk +0 lines, -10 lines 0 comments Download
D chrome/browser/ui/webui/options/handler_options_handler.h View 1 2 3 4 5 6 1 chunk +0 lines, -76 lines 0 comments Download
D chrome/browser/ui/webui/options/handler_options_handler.cc View 1 2 3 4 5 6 1 chunk +0 lines, -205 lines 0 comments Download
D chrome/browser/ui/webui/options/import_data_handler.h View 1 2 3 4 5 6 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/browser/ui/webui/options/import_data_handler.cc View 1 2 3 4 5 6 1 chunk +0 lines, -178 lines 0 comments Download
D chrome/browser/ui/webui/options/language_options_browsertest.js View 1 2 3 4 5 6 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser/ui/webui/options/language_options_handler.h View 1 2 3 4 5 6 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/browser/ui/webui/options/language_options_handler.cc View 1 2 3 4 5 6 1 chunk +0 lines, -119 lines 0 comments Download
D chrome/browser/ui/webui/options/language_options_handler_common.h View 1 2 3 4 5 6 1 chunk +0 lines, -69 lines 0 comments Download
D chrome/browser/ui/webui/options/language_options_handler_common.cc View 1 2 3 4 5 6 1 chunk +0 lines, -168 lines 0 comments Download
D chrome/browser/ui/webui/options/language_options_handler_unittest.cc View 1 2 3 4 5 6 1 chunk +0 lines, -208 lines 0 comments Download
D chrome/browser/ui/webui/options/manage_profile_handler.h View 1 2 3 4 5 6 1 chunk +0 lines, -82 lines 0 comments Download
D chrome/browser/ui/webui/options/manage_profile_handler.cc View 1 2 3 4 5 6 1 chunk +0 lines, -312 lines 0 comments Download
D chrome/browser/ui/webui/options/options_browsertest.js View 1 2 3 4 5 6 1 chunk +0 lines, -86 lines 0 comments Download
D chrome/browser/ui/webui/options/options_sync_setup_handler.h View 1 2 3 4 5 6 1 chunk +0 lines, -21 lines 0 comments Download
D chrome/browser/ui/webui/options/options_sync_setup_handler.cc View 1 2 3 4 5 6 1 chunk +0 lines, -23 lines 0 comments Download
D chrome/browser/ui/webui/options/options_ui_uitest.h View 1 2 3 4 5 6 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/ui/webui/options/options_ui_uitest.cc View 1 2 3 4 5 6 1 chunk +0 lines, -65 lines 0 comments Download
D chrome/browser/ui/webui/options/pack_extension_handler.h View 1 2 3 4 5 6 1 chunk +0 lines, -55 lines 0 comments Download
D chrome/browser/ui/webui/options/pack_extension_handler.cc View 1 2 3 4 5 6 1 chunk +0 lines, -124 lines 0 comments Download
D chrome/browser/ui/webui/options/password_manager_browsertest.js View 1 2 3 4 5 6 1 chunk +0 lines, -25 lines 0 comments Download
D chrome/browser/ui/webui/options/password_manager_handler.h View 1 2 3 4 5 6 1 chunk +0 lines, -129 lines 0 comments Download
D chrome/browser/ui/webui/options/password_manager_handler.cc View 1 2 3 4 5 6 1 chunk +0 lines, -290 lines 0 comments Download
D chrome/browser/ui/webui/options/personal_options_browsertest.js View 1 2 3 4 5 6 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser/ui/webui/options/personal_options_handler.h View 1 2 3 4 5 6 1 chunk +0 lines, -70 lines 0 comments Download
D chrome/browser/ui/webui/options/personal_options_handler.cc View 1 2 3 4 5 6 1 chunk +0 lines, -443 lines 0 comments Download
D chrome/browser/ui/webui/options/search_engine_manager_browsertest.js View 1 2 3 4 5 6 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/browser/ui/webui/options/search_engine_manager_handler.h View 1 2 3 4 5 6 1 chunk +0 lines, -79 lines 0 comments Download
D chrome/browser/ui/webui/options/search_engine_manager_handler.cc View 1 2 3 4 5 6 1 chunk +0 lines, -311 lines 0 comments Download
D chrome/browser/ui/webui/options/stop_syncing_handler.h View 1 2 3 4 5 6 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/browser/ui/webui/options/stop_syncing_handler.cc View 1 2 3 4 5 6 1 chunk +0 lines, -55 lines 0 comments Download
D chrome/browser/ui/webui/options/web_intents_settings_handler.h View 1 2 3 4 5 6 1 chunk +0 lines, -77 lines 0 comments Download
D chrome/browser/ui/webui/options/web_intents_settings_handler.cc View 1 2 3 4 5 6 1 chunk +0 lines, -160 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/accounts_options_handler2.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/bluetooth_options_handler2.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/change_picture_options_handler2.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/core_chromeos_options_handler2.h View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/guest_mode_options_ui2_uitest.cc View 1 2 3 4 5 6 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/keyboard_handler2.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/language_chewing_handler2.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/language_hangul_handler2.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/language_mozc_handler2.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/language_pinyin_handler2.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/pointer_handler2.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/proxy_handler2.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/set_wallpaper_options_handler2.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/stats_options_handler2.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/virtual_keyboard_manager_handler2.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options2/language_options_handler2_unittest.cc View 1 2 3 4 5 6 4 chunks +6 lines, -4 lines 0 comments Download
A + chrome/browser/ui/webui/options2/options_sync_setup_handler.h View 1 2 3 4 5 6 2 chunks +7 lines, -3 lines 0 comments Download
A + chrome/browser/ui/webui/options2/options_sync_setup_handler.cc View 1 2 3 4 5 6 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options2/options_ui2.h View 1 2 3 4 5 6 2 chunks +68 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options2/options_ui2.cc View 1 2 3 4 5 6 3 chunks +40 lines, -2 lines 1 comment Download
M chrome/browser/ui/webui/options2/options_ui2_uitest.cc View 1 2 3 4 5 6 3 chunks +1 line, -15 lines 1 comment Download
A + chrome/browser/ui/webui/options2/stop_syncing_handler.h View 1 2 3 4 5 6 2 chunks +9 lines, -5 lines 0 comments Download
A + chrome/browser/ui/webui/options2/stop_syncing_handler.cc View 1 2 3 4 5 6 3 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/sync_setup_browsertest.js View 1 2 3 4 5 6 3 chunks +7 lines, -6 lines 2 comments Download
M chrome/browser/ui/webui/sync_setup_handler.h View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 4 chunks +8 lines, -90 lines 0 comments Download
M chrome/chrome_repack_resources.gypi View 1 2 3 4 5 6 2 chunks +1 line, -2 lines 0 comments Download
M chrome/chrome_resources.gyp View 1 2 3 4 5 6 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 6 3 chunks +19 lines, -18 lines 1 comment Download
M chrome/common/chrome_switches.h View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 4 5 6 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/url_constants.h View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/url_constants.cc View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/automation/automation_proxy_uitest.cc View 1 2 3 4 5 6 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/reliability/automated_ui_test_test.cc View 1 2 3 4 5 6 1 chunk +4 lines, -2 lines 1 comment Download
M chrome/test/ui/ui_test.cc View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Evan Stade
8 years, 9 months ago (2012-03-22 04:42:47 UTC) #1
Dan Beam
This is failing a lot of related tests at the moment, btw.
8 years, 9 months ago (2012-03-22 16:20:42 UTC) #2
csilv
I reviewed this CL and it LG, but I'll stamp it with green trybots. In ...
8 years, 9 months ago (2012-03-22 19:41:02 UTC) #3
Dan Beam
8 years, 9 months ago (2012-03-23 03:25:31 UTC) #4 
I left off various capitalization and nits, nothing should prevent you from
landing tonight, lgtm

https://chromiumcodereview.appspot.com/9814030/diff/25339/chrome/browser/ui/w...
File chrome/browser/ui/webui/bidi_checker_web_ui_test.cc (right):

https://chromiumcodereview.appspot.com/9814030/diff/25339/chrome/browser/ui/w...
chrome/browser/ui/webui/bidi_checker_web_ui_test.cc:102: //
chrome://settings/history
chrome://chrome/history

https://chromiumcodereview.appspot.com/9814030/diff/25339/chrome/browser/ui/w...
File chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc (right):

https://chromiumcodereview.appspot.com/9814030/diff/25339/chrome/browser/ui/w...
chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc:231: // Android
doesn't use the Options pages.
merge conflict?

https://chromiumcodereview.appspot.com/9814030/diff/25339/chrome/browser/ui/w...
File chrome/browser/ui/webui/chromeos/login/oobe_ui.cc (right):

https://chromiumcodereview.appspot.com/9814030/diff/25339/chrome/browser/ui/w...
chrome/browser/ui/webui/chromeos/login/oobe_ui.cc:173:
options2::UserImageSource* user_image_source = new options2::UserImageSource();
80 char wrap

https://chromiumcodereview.appspot.com/9814030/diff/25339/chrome/browser/ui/w...
File chrome/browser/ui/webui/options2/options_ui2.cc (right):

https://chromiumcodereview.appspot.com/9814030/diff/25339/chrome/browser/ui/w...
chrome/browser/ui/webui/options2/options_ui2.cc:182: size_t length) {
er, why do we need |length|?

https://chromiumcodereview.appspot.com/9814030/diff/25339/chrome/browser/ui/w...
File chrome/browser/ui/webui/options2/options_ui2_uitest.cc (left):

https://chromiumcodereview.appspot.com/9814030/diff/25339/chrome/browser/ui/w...
chrome/browser/ui/webui/options2/options_ui2_uitest.cc:42: 
TODO(estade): Rewrite for uberpage?

https://chromiumcodereview.appspot.com/9814030/diff/25339/chrome/browser/ui/w...
File chrome/browser/ui/webui/sync_setup_browsertest.js (right):

https://chromiumcodereview.appspot.com/9814030/diff/25339/chrome/browser/ui/w...
chrome/browser/ui/webui/sync_setup_browsertest.js:37: verifyUnsynced: function()
{
sweet test

https://chromiumcodereview.appspot.com/9814030/diff/25339/chrome/browser/ui/w...
chrome/browser/ui/webui/sync_setup_browsertest.js:79: // TODO(estade): this
doesn't work. DidShowPage is called multiple times.
bug #?

https://chromiumcodereview.appspot.com/9814030/diff/25339/chrome/chrome_tests...
File chrome/chrome_tests.gypi (right):

https://chromiumcodereview.appspot.com/9814030/diff/25339/chrome/chrome_tests...
chrome/chrome_tests.gypi:2834: # TODO(estade): enable these.
bug #?

https://chromiumcodereview.appspot.com/9814030/diff/25339/chrome/test/reliabi...
File chrome/test/reliability/automated_ui_test_test.cc (right):

https://chromiumcodereview.appspot.com/9814030/diff/25339/chrome/test/reliabi...
chrome/test/reliability/automated_ui_test_test.cc:432:
GURL(std::string(chrome::kChromeUIUberURL) +
nit: seems like this should be on same line as ASSERT_EQ( with url lined up to
end paren, but you know chrome code better than I...

Powered by Google App Engine
This is Rietveld 408576698